Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/Source/bindings/scripts/idl_definitions.py

Issue 2683853005: bindings: Make some value iterator properties aliases to Array.prototype functions (Closed)
Patch Set: Remove constexpr from Internals.h to fix the Android build Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/idl_definitions.py
diff --git a/third_party/WebKit/Source/bindings/scripts/idl_definitions.py b/third_party/WebKit/Source/bindings/scripts/idl_definitions.py
index 8dc6a3376fad1a94e639dd9bb8558091b161d928..678a149d81c548bad1f6b5b08b50de9e2af91774 100644
--- a/third_party/WebKit/Source/bindings/scripts/idl_definitions.py
+++ b/third_party/WebKit/Source/bindings/scripts/idl_definitions.py
@@ -355,6 +355,10 @@ class IdlInterface(object):
if has_integer_typed_length and has_indexed_property_getter:
self.has_indexed_elements = True
+ else:
+ if self.iterable is not None and self.iterable.key_type is None:
+ raise ValueError('Value iterators (iterable<V>) must be accompanied by an indexed '
+ 'property getter and an integer-typed length attribute.')
def accept(self, visitor):
visitor.visit_interface(self)
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/Iterable.h ('k') | third_party/WebKit/Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698