bindings: Make some value iterator properties aliases to Array.prototype functions

third_party/WebKit/Source/bindings/core/v8/Iterable.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef Iterable_h
 #define Iterable_h
 
 #include "bindings/core/v8/V8IteratorResultValue.h"
 #include "bindings/core/v8/V8ScriptRunner.h"
 #include "core/dom/Iterator.h"
 
 namespace blink {
 
-// Typically, use one of ValueIterable<> and PairIterable<> (below) instead!
+// Typically, you should use PairIterable<> (below) instead.
+// Also, note that value iterators are set up automatically by the bindings
+// code and the operations below come directly from V8.
 template <typename KeyType, typename ValueType>
 class Iterable {
  public:
   Iterator* keysForBinding(ScriptState* scriptState,
                            ExceptionState& exceptionState) {
     IterationSource* source = this->startIteration(scriptState, exceptionState);
     if (!source)
       return nullptr;
     return new IterableIterator<KeySelector>(source);
   }
@@ skipping 133 matching lines @@
       visitor->trace(m_source);
       Iterator::trace(visitor);
     }
 
    private:
     Member<IterationSource> m_source;
   };
 };
 
 // Utiltity mixin base-class for classes implementing IDL interfaces with
-// "iterable<T>".
-template <typename ValueType>
-class ValueIterable : public Iterable<unsigned, ValueType> {
- public:
-  Iterator* iterator(ScriptState* scriptState, ExceptionState& exceptionState) {
-    return this->valuesForBinding(scriptState, exceptionState);
-  }
-
-  class IterationSource
-      : public Iterable<unsigned, ValueType>::IterationSource {
-   public:
-    IterationSource() : m_index(0) {}
-
-    ~IterationSource() override {}
-
-    // If end of iteration has been reached or an exception thrown: return
-    // false.
-    // Otherwise: set |value| and return true.
-    // Note: |this->m_index| is the index being accessed.
-    virtual bool next(ScriptState*, ValueType&, ExceptionState&) = 0;
-
-   protected:
-    unsigned m_index;
-
-   private:
-    bool next(ScriptState* scriptState,
-              unsigned& key,
-              ValueType& value,
-              ExceptionState& exceptionState) final {
-      if (!next(scriptState, value, exceptionState))
-        return false;
-      key = m_index;
-      ++m_index;
-      return true;
-    }
-  };
-};
-
-// Utiltity mixin base-class for classes implementing IDL interfaces with
 // "iterable<T1, T2>".
 template <typename KeyType, typename ValueType>
 class PairIterable : public Iterable<KeyType, ValueType> {
  public:
   Iterator* iterator(ScriptState* scriptState, ExceptionState& exceptionState) {
     return this->entriesForBinding(scriptState, exceptionState);
   }
 };
 
 }  // namespace blink
 
 #endif  // Iterable_h