Disable DateTime, Color, and Select popups when in VR

components/web_contents_delegate_android/web_contents_delegate_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/web_contents_delegate_android/web_contents_delegate_android.h"
 
 #include <android/keycodes.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 40 matching lines @@
 }
 
 // ----------------------------------------------------------------------------
 // WebContentsDelegate methods
 // ----------------------------------------------------------------------------
 
 ColorChooser* WebContentsDelegateAndroid::OpenColorChooser(
       WebContents* source,
       SkColor color,
       const std::vector<content::ColorSuggestion>& suggestions)  {
+  if (source->GetRenderWidgetHostView()->IsInVR()) {

[boliu, 2017/03/06 22:38:10]

instead of this check, make sure content doesn't call this in vr mode

then you don't need to expose IsInVR from content

+    // TODO(billorr): Add VR color chooser support. See crbug.com/661243.
+    NOTIMPLEMENTED();

[mthiesse, 2017/02/08 18:27:57]

I don't think we actually want NOTIMPLEMENTED() here... won't that possibly
cause crashes depending on the policy at the time?

We definitely expect this code to be run, so it's not so much unimplemented as
it is disabled.

[mthiesse, 2017/02/08 18:29:12]

Nevermind the crashes point, I see that it either logs or fails to compile. I
still think we don't want to be logging here.

[billorr, 2017/02/08 19:02:46]

I was on the fence about adding it.  I figured the extra logging is one more
reminder that we have to fix this, it documents in the code and logs that it
isn't expected to work, and since it isn't called in some loop the logs won't be
flooded with notifications that something isn't implemented.

If you feel strongly, I can remove it, but it won't be harmful.

[mthiesse, 2017/02/08 19:24:46]

It's somewhat harmful, strings are a large contributor to binary size, so
pointless logging is heavily discouraged.

[amp, 2017/02/08 19:31:40]

Policy on Android official builds seems to be to strip them out, see:
https://cs.chromium.org/chromium/src/base/logging.h?q=NOTIMPLEMENTED_POLICY&s...

My vote is to keep them in, seems like they would be useful on dev builds and
won't impact the release builds size.

+    return nullptr;
+  }
   return new ColorChooserAndroid(source, color, suggestions);
 }
 
 // OpenURLFromTab() will be called when we're performing a browser-intiated
 // navigation. The most common scenario for this is opening new tabs (see
 // RenderViewImpl::decidePolicyForNavigation for more details).
 WebContents* WebContentsDelegateAndroid::OpenURLFromTab(
     WebContents* source,
     const content::OpenURLParams& params) {
   const GURL& url = params.url;
@@ skipping 342 matching lines @@
     validation_message_bubble_->SetPositionRelativeToAnchor(
         rwhv->GetRenderWidgetHost(), anchor_in_root_view);
   }
 }
 
 void WebContentsDelegateAndroid::RequestAppBannerFromDevTools(
     content::WebContents* web_contents) {
 }
 
 }  // namespace web_contents_delegate_android