Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2683793003: Add failing test (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
devoncarew, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed path issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
A pkg/analysis_server/test/integration/execution/map_uri_test.dart View 1 1 chunk +46 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/execution/test_all.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
This adds a test showing that the execution.mapUri request is broken under the new driver. ...
3 years, 10 months ago (2017-02-08 01:23:02 UTC) #2
scheglov
https://codereview.chromium.org/2683793003/diff/1/pkg/analysis_server/test/integration/execution/map_uri_test.dart File pkg/analysis_server/test/integration/execution/map_uri_test.dart (right): https://codereview.chromium.org/2683793003/diff/1/pkg/analysis_server/test/integration/execution/map_uri_test.dart#newcode31 pkg/analysis_server/test/integration/execution/map_uri_test.dart:31: expect(result.file, '/private' + pathname); From where does /private come?
3 years, 10 months ago (2017-02-08 01:30:17 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2683793003/diff/1/pkg/analysis_server/test/integration/execution/map_uri_test.dart File pkg/analysis_server/test/integration/execution/map_uri_test.dart (right): https://codereview.chromium.org/2683793003/diff/1/pkg/analysis_server/test/integration/execution/map_uri_test.dart#newcode31 pkg/analysis_server/test/integration/execution/map_uri_test.dart:31: expect(result.file, '/private' + pathname); Good catch. I believe that ...
3 years, 10 months ago (2017-02-08 15:53:29 UTC) #4
Brian Wilkerson
Updated. PTAL.
3 years, 10 months ago (2017-02-08 16:06:11 UTC) #5
scheglov
LGTM
3 years, 10 months ago (2017-02-08 16:09:04 UTC) #6
Brian Wilkerson
3 years, 10 months ago (2017-02-08 16:13:43 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a69189972cb5db1a2171aa617e1d132b2f4b8665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698