cc: make resource keep video buffer format for hardware overlay.

cc/output/overlay_candidate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/output/overlay_candidate.h"
 
 #include <algorithm>
 #include <limits>
 #include "base/logging.h"
 #include "cc/base/math_util.h"
@@ skipping 268 matching lines @@
   candidate->uv_rect = BoundingRect(quad->uv_top_left, quad->uv_bottom_right);
   return true;
 }
 
 // static
 bool OverlayCandidate::FromStreamVideoQuad(ResourceProvider* resource_provider,
                                            const StreamVideoDrawQuad* quad,
                                            OverlayCandidate* candidate) {
   if (!resource_provider->IsOverlayCandidate(quad->resource_id()))
     return false;
+  candidate->format = resource_provider->GetBufferFormat(quad->resource_id());

[Daniele Castagna, 2017/03/28 02:01:39]

We're not supposed to use the StreamVideoQuad on CrOS.
StreamVideoQuad was added for Android and it is accidentally used in CrOS at the
moment.

crrev.com/2763223003 to limit the usage only to Android.

[dshwang, 2017/03/28 16:42:25]

wow, that's why cros use StreamVideoQuad recently.

By the way, this CL is still valid, because it's not very related to
StreamVideoQuad. It rather makes video_layer_impl set buffer format to resource
for mailbox resource. Without this change, TextureQuad from video cannot know
buffer format. In addition, even though this line isn't used by cros, I think
it's not bad to keep it.

+  if (std::find(std::begin(kOverlayFormats), std::end(kOverlayFormats),
+                candidate->format) == std::end(kOverlayFormats))
+    return false;
   gfx::OverlayTransform overlay_transform = GetOverlayTransform(
       quad->shared_quad_state->quad_to_target_transform, false);
   if (overlay_transform == gfx::OVERLAY_TRANSFORM_INVALID)
     return false;
   if (!quad->matrix.IsScaleOrTranslation()) {
     // We cannot handle anything other than scaling & translation for texture
     // coordinates yet.
     return false;
   }
   candidate->resource_id = quad->resource_id();
@@ skipping 46 matching lines @@
 
 OverlayCandidateList& OverlayCandidateList::operator=(
     OverlayCandidateList&& other) = default;
 
 void OverlayCandidateList::AddPromotionHint(const OverlayCandidate& candidate) {
   promotion_hint_info_map_[candidate.resource_id] =
       candidate.display_rect.origin();
 }
 
 }  // namespace cc