cc: make resource keep video buffer format for hardware overlay.

components/display_compositor/compositor_overlay_candidate_validator_ozone.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/display_compositor/compositor_overlay_candidate_validator_ozone.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 10 matching lines @@
 // Templated function used to create an OverlayProcessor::Strategy
 // of type |S|.
 template <typename S>
 std::unique_ptr<cc::OverlayProcessor::Strategy> MakeOverlayStrategy(
     CompositorOverlayCandidateValidatorOzone* capability_checker) {
   return base::MakeUnique<S>(capability_checker);
 }
 
 }  // namespace
 
-static gfx::BufferFormat GetBufferFormat(cc::ResourceFormat overlay_format) {
-  switch (overlay_format) {
-    // TODO(dshwang): overlay video still uses RGBA_8888.
-    case cc::RGBA_8888:
-    case cc::BGRA_8888:
-      return gfx::BufferFormat::BGRA_8888;
-    default:
-      NOTREACHED();
-      return gfx::BufferFormat::BGRA_8888;
-  }
-}
-
 // |overlay_candidates| is an object used to answer questions about possible
 // overlays configuarations.
 // |strategies_string| is a comma-separated string containing all the overaly
 // strategies that should be returned by GetStrategies.
 // If |strategies_string| is empty "single-on-top,underlay" will be used as
 // default.
 CompositorOverlayCandidateValidatorOzone::
     CompositorOverlayCandidateValidatorOzone(
         std::unique_ptr<ui::OverlayCandidatesOzone> overlay_candidates,
         std::string strategies_string)
@@ skipping 43 matching lines @@
     }
     return;
   }
 
   DCHECK_GE(2U, surfaces->size());
   ui::OverlayCandidatesOzone::OverlaySurfaceCandidateList ozone_surface_list;
   ozone_surface_list.resize(surfaces->size());
 
   for (size_t i = 0; i < surfaces->size(); i++) {
     ozone_surface_list.at(i).transform = surfaces->at(i).transform;
-    ozone_surface_list.at(i).format = GetBufferFormat(surfaces->at(i).format);
+    ozone_surface_list.at(i).format = surfaces->at(i).format;

[Daniele Castagna, 2017/02/08 18:59:48]

This would now pass the format even if it's not an RGB format while we used to
accept only RGBA/BGRA.
Should we validate the format somewhere?

[dshwang, 2017/02/09 00:03:54]

Yes, DrmOverlayManager::CheckOverlaySupport() checks whether the format is
supported or not.

Actually, DrmOverlayValidator::TestPageFlip() queries the plane list (with
format) is supported to drm device (by ioctl call).

Above hack was introduced when drm doesn't support RGBA format, but it's stale.

     ozone_surface_list.at(i).display_rect = surfaces->at(i).display_rect;
     ozone_surface_list.at(i).crop_rect = surfaces->at(i).uv_rect;
     ozone_surface_list.at(i).quad_rect_in_target_space =
         surfaces->at(i).quad_rect_in_target_space;
     ozone_surface_list.at(i).clip_rect = surfaces->at(i).clip_rect;
     ozone_surface_list.at(i).is_clipped = surfaces->at(i).is_clipped;
     ozone_surface_list.at(i).plane_z_order = surfaces->at(i).plane_z_order;
     ozone_surface_list.at(i).buffer_size =
         surfaces->at(i).resource_size_in_pixels;
   }
 
   overlay_candidates_->CheckOverlaySupport(&ozone_surface_list);
   DCHECK_EQ(surfaces->size(), ozone_surface_list.size());
 
   for (size_t i = 0; i < surfaces->size(); i++) {
     surfaces->at(i).overlay_handled = ozone_surface_list.at(i).overlay_handled;
     surfaces->at(i).display_rect = ozone_surface_list.at(i).display_rect;
   }
 }
 
 void CompositorOverlayCandidateValidatorOzone::SetSoftwareMirrorMode(
     bool enabled) {
   software_mirror_active_ = enabled;
 }
 
 }  // namespace display_compositor