Add error messsage bubble flag for tests.

chrome/browser/resources/login/display_manager.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Display manager for WebUI OOBE and login.
  */
 
 // TODO(xiyuan): Find a better to share those constants.
 /** @const */ var SCREEN_OOBE_NETWORK = 'connect';
@@ skipping 160 matching lines @@
      * @type {boolean}
      */
     forceKeyboardFlow_: false,
 
     /**
      * Type of UI.
      * @type {string}
      */
     displayType_: DISPLAY_TYPE.UNKNOWN,
 
+    /**
+     * Error message (bubble) was shown. This is checked in tests.
+     */
+    errorMessageWasShownForTesting_: false,

[achuithb, 2014/05/07 20:38:32]

We have a number of testing apis here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

Should we add this to login_common.js, or is this the best place for this? We
may need to set more variables in the future for testing.

[Alexander Alekseev, 2014/05/07 21:00:16]

I think the less code "for testing only" we add to production code,
the less complex code we get. Keeping this flag close to the set/clear code for
it is probably easier to support. So I would probably leave it here.

[achuithb, 2014/05/07 21:10:03]

sg

+
     get displayType() {
       return this.displayType_;
     },
 
     set displayType(displayType) {
       this.displayType_ = displayType;
       document.documentElement.setAttribute('screen', displayType);
     },
 
     get newKioskUI() {
@@ skipping 678 matching lines @@
       helpLink.href = '#';
       helpLink.textContent = link;
       helpLink.addEventListener('click', function(e) {
         chrome.send('launchHelpApp', [helpId]);
         e.preventDefault();
       });
       error.appendChild(helpLink);
     }
 
     var currentScreen = Oobe.getInstance().currentScreen;
-    if (currentScreen && typeof currentScreen.showErrorBubble === 'function')
+    if (currentScreen && typeof currentScreen.showErrorBubble === 'function') {
       currentScreen.showErrorBubble(loginAttempts, error);
+      this.errorMessageWasShownForTesting_ = true;
+    }
   };
 
   /**
    * Shows password changed screen that offers migration.
    * @param {boolean} showError Whether to show the incorrect password error.
    */
   DisplayManager.showPasswordChangedScreen = function(showError) {
     login.PasswordChangedScreen.show(showError);
   };
 
   /**
    * Shows dialog to create managed user.
    */
   DisplayManager.showManagedUserCreationScreen = function() {
     login.ManagedUserCreationScreen.show();
   };
 
   /**
    * Shows TPM error screen.
    */
   DisplayManager.showTpmError = function() {
     login.TPMErrorMessageScreen.show();
   };
 
   /**
    * Clears error bubble.
    */
   DisplayManager.clearErrors = function() {
     $('bubble').hide();
+    this.errorMessageWasShownForTesting_ = false;
   };
 
   /**
    * Sets text content for a div with |labelId|.
    * @param {string} labelId Id of the label div.
    * @param {string} labelText Text for the label.
    */
   DisplayManager.setLabelText = function(labelId, labelText) {
     $(labelId).textContent = labelText;
   };
@@ skipping 33 matching lines @@
    */
   DisplayManager.refocusCurrentPod = function() {
     $('pod-row').refocusCurrentPod();
   };
 
   // Export
   return {
     DisplayManager: DisplayManager
   };
 });