Add error messsage bubble flag for tests.

Add error messsage bubble flag for tests.

Tests checking for eroro message buble can be flaky, because on-screen message
can disappear before test checks for it. This CL adds special flag for tests.

BUG=339348
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268924

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269773

[Alexander Alekseev, 2014-05-07 01:33:31]

Please review.

[Denis Kuznetsov (DE-MUC), 2014-05-07 12:33:57]

lgtm

[commit-bot: I haz the power, 2014-05-07 12:37:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alemate@chromium.org/268373002/1

[commit-bot: I haz the power, 2014-05-07 20:32:26]

Change committed as 268924

[achuithb, 2014-05-07 20:38:31]

Thanks for working on this. lgtm

https://codereview.chromium.org/268373002/diff/1/chrome/browser/resources/log...
File chrome/browser/resources/login/display_manager.js (right):

https://codereview.chromium.org/268373002/diff/1/chrome/browser/resources/log...
chrome/browser/resources/login/display_manager.js:184:
errorMessageWasShownForTesting_: false,
We have a number of testing apis here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

Should we add this to login_common.js, or is this the best place for this? We
may need to set more variables in the future for testing.

[Alexander Alekseev, 2014-05-07 21:00:15]

https://codereview.chromium.org/268373002/diff/1/chrome/browser/resources/log...
File chrome/browser/resources/login/display_manager.js (right):

https://codereview.chromium.org/268373002/diff/1/chrome/browser/resources/log...
chrome/browser/resources/login/display_manager.js:184:
errorMessageWasShownForTesting_: false,
On 2014/05/07 20:38:32, achuithb wrote:
> We have a number of testing apis here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> 
> Should we add this to login_common.js, or is this the best place for this? We
> may need to set more variables in the future for testing.

I think the less code "for testing only" we add to production code,
the less complex code we get. Keeping this flag close to the set/clear code for
it is probably easier to support. So I would probably leave it here.

[achuithb, 2014-05-07 21:10:02]

https://codereview.chromium.org/268373002/diff/1/chrome/browser/resources/log...
File chrome/browser/resources/login/display_manager.js (right):

https://codereview.chromium.org/268373002/diff/1/chrome/browser/resources/log...
chrome/browser/resources/login/display_manager.js:184:
errorMessageWasShownForTesting_: false,
On 2014/05/07 21:00:16, alemate wrote:
> On 2014/05/07 20:38:32, achuithb wrote:
> > We have a number of testing apis here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> > 
> > Should we add this to login_common.js, or is this the best place for this?
We
> > may need to set more variables in the future for testing.
> 
> I think the less code "for testing only" we add to production code,
> the less complex code we get. Keeping this flag close to the set/clear code
for
> it is probably easier to support. So I would probably leave it here.

sg

[Alexander Alekseev, 2014-05-08 17:47:52]

A revert of this CL has been created in
https://codereview.chromium.org/271823005/ by alemate@chromium.org.

The reason for reverting is: Win tests are failing. Reverting to check if this
CL is to blame..

[Alexander Alekseev, 2014-05-12 12:50:36]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2014-05-12 12:50:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alemate@chromium.org/268373002/1

[commit-bot: I haz the power, 2014-05-12 12:51:52]

Change committed as 269773