Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2683713004: DevTools: revert of timestamp format dropdown (Closed)
Patch Set: wrong upstream Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index c9920b02c78d85d4db7a8440ec974c528415e7b6..938f3bba5ebc606ba6cdfb875079c211159f9929 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -150,7 +150,7 @@ Console.ConsoleView = class extends UI.VBox {
this._consoleHistoryAutocompleteChanged();
this._updateFilterStatus();
- Common.moduleSetting('consoleTimestampFormat').addChangeListener(this._consoleTimestampsSettingChanged, this);
+ Common.moduleSetting('consoleTimestampsEnabled').addChangeListener(this._consoleTimestampsSettingChanged, this);
this._registerWithMessageSink();
SDK.targetManager.observeTargets(this);
@@ -676,8 +676,7 @@ Console.ConsoleView = class extends UI.VBox {
* @return {boolean}
*/
_tryToCollapseMessages(lastMessage, viewMessage) {
- var timestampFormat = Common.moduleSetting('consoleTimestampFormat').get();
- var timestampsShown = timestampFormat !== Console.ConsoleViewMessage.TimestampFormat.None;
+ var timestampsShown = Common.moduleSetting('consoleTimestampsEnabled').get();
if (!timestampsShown && viewMessage && !lastMessage.consoleMessage().isGroupMessage() &&
lastMessage.consoleMessage().isEqual(viewMessage.consoleMessage())) {
viewMessage.incrementRepeatCount();

Powered by Google App Engine
This is Rietveld 408576698