[dart:io] A small boringssl cleanup from davidben@

runtime/bin/secure_socket_boringssl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED) && !defined(DART_IO_SECURE_SOCKET_DISABLED)
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID) || defined(TARGET_OS_LINUX) ||                  \
     defined(TARGET_OS_WINDOWS) || defined(TARGET_OS_FUCHSIA)
 
@@ skipping 73 matching lines @@
 // null-terminated string.
 static void FetchErrorString(const SSL* ssl, TextBuffer* text_buffer) {
   uint32_t error = 0;
   const char* path = NULL;
   int line = -1;
   const char* sep = File::PathSeparator();
   do {
     error = ERR_get_error_line(&path, &line);
     const char* file = strrchr(path, sep[0]);
     path = file ? file + 1 : path;
-    if ((ssl != NULL) &&
-        (error == ERR_PACK(ERR_R_SSL_LIB, SSL_R_CERTIFICATE_VERIFY_FAILED))) {
+    if ((ssl != NULL) && (ERR_GET_LIB(error) == ERR_LIB_SSL) &&
+        (ERR_GET_REASON(error) == SSL_R_CERTIFICATE_VERIFY_FAILED)) {
       intptr_t result = SSL_get_verify_result(ssl);
       text_buffer->Printf("\n\t%s: %s (%s:%d)", ERR_reason_error_string(error),
                           X509_verify_cert_error_string(result), path, line);
     } else if (error != 0) {
       text_buffer->Printf("\n\t%s (%s:%d)", ERR_reason_error_string(error),
                           path, line);
     }
   } while (error != 0);
 }
 
@@ skipping 1680 matching lines @@
   return bytes_processed;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_LINUX)
 
 #endif  // !defined(DART_IO_DISABLED) &&
         // !defined(DART_IO_SECURE_SOCKET_DISABLED)