chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 2683653007: Show a Google "G" in the omnibox on the New Tab Page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2683653007: Show a Google "G" in the omnibox on the New Tab Page. (Closed)

Patch Set: comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index 603750ad1a786ddaea6ffe267f23584b2435193f..da700a461902a3ecd7011ae707d170feecaf95e6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -296,8 +296,14 @@ public class NewTabPageView

TraceEvent.begin(TAG + ".initializeSearchBoxTextView()");

final TextView searchBoxTextView = (TextView) mSearchBoxView

.findViewById(R.id.search_box_text);

- String hintText = getResources().getString(R.string.search_or_type_url);

+ if (!ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SHOW_GOOGLE_G_IN_OMNIBOX)) {

+ // Not using the relative version of this call because we only want to clear

+ // the drawables.

+ searchBoxTextView.setCompoundDrawables(null, null, null, null);

+ }

+ String hintText = getResources().getString(R.string.search_or_type_url);

if (!DeviceFormFactor.isTablet(getContext()) || mManager.isFakeOmniboxTextEnabledTablet()) {

searchBoxTextView.setHint(hintText);

} else {