third_party/WebKit/LayoutTests/media/track/track-cue-rendering-position-auto.html - Issue 2683633006: [WebVTT] Rename Middle to Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-position-auto.html

Issue 2683633006: [WebVTT] Rename Middle to Center (Closed)

Patch Set: fix tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-mutable.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-rendering-position-auto-rtl.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../media-file.js"></script>	2 <script src="../media-file.js"></script>

3 <script>	3 <script>

4 var mediaFile = findMediaFile('video', '../content/test');	4 var mediaFile = findMediaFile('video', '../content/test');

5	5

6 function addTrackWithCueData(video, cueData) {	6 function addTrackWithCueData(video, cueData) {

7 var track = video.addTextTrack('subtitles');	7 var track = video.addTextTrack('subtitles');

8 var cue = new VTTCue(0, 10, 'XXX');	8 var cue = new VTTCue(0, 10, 'XXX');

9 for (var prop in cueData)	9 for (var prop in cueData)

10 cue[prop] = cueData[prop];	10 cue[prop] = cueData[prop];

(...skipping 11 matching lines...) Expand all Loading...
22 <video>	22 <video>

23 <script>	23 <script>

24 var video = document.currentScript.parentNode;	24 var video = document.currentScript.parentNode;

25 addTrackWithCueData(video, { align: 'start', line: 0 });	25 addTrackWithCueData(video, { align: 'start', line: 0 });

26 video.src = mediaFile;	26 video.src = mediaFile;

27 </script>	27 </script>

28 </video>	28 </video>

29 <video>	29 <video>

30 <script>	30 <script>

31 var video = document.currentScript.parentNode;	31 var video = document.currentScript.parentNode;

32 addTrackWithCueData(video, { align: 'middle', line: 0 });	32 addTrackWithCueData(video, { align: 'center', line: 0 });

33 video.src = mediaFile;	33 video.src = mediaFile;

34 </script>	34 </script>

35 </video>	35 </video>

36 <video>	36 <video>

37 <script>	37 <script>

38 var video = document.currentScript.parentNode;	38 var video = document.currentScript.parentNode;

39 addTrackWithCueData(video, { align: 'end', line: 0 });	39 addTrackWithCueData(video, { align: 'end', line: 0 });

40 video.src = mediaFile;	40 video.src = mediaFile;

41 </script>	41 </script>

42 </video>	42 </video>

OLD	NEW