Issue 268363019: Let test runner rerun failures to test for flakes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268363019: Let test runner rerun failures to test for flakes. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach

Modified:
6 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Let test runner rerun failures to test for flakes. BUG=

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -40 lines)			Patch
M	tools/run-tests.py	View	3 chunks	+66 lines, -40 lines	0 comments	Download
M	tools/testrunner/local/execution.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/testrunner/objects/testcase.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

PTAL. TODOs are left for follow up CLs. The script does not yet hide any ...

6 years, 7 months ago (2014-05-08 13:09:24 UTC) #1

Jakob Kummerow

6 years, 7 months ago (2014-05-08 13:59:01 UTC) #2

To summarize our offline discussion: rather than invoking the entire machinery
again, test retrying should preferably be done within _RunInternal() in
execution.py, right after observing the failure. Also, the feature should be
off-by-default, since it's likely not desirable for interactive use of the test
driver during day-to-day development (we could have the existing --buildbot flag
trigger it).

Expand Messages | Collapse Messages