V4L2VDA: Add more NALU types that indicate end of current frame data.

V4L2VDA: Add more NALU types that indicate end of current frame data.
    
Add AUD, SEI and reserved NALU types to the set of NALUs that
trigger the end of current frame, i.e. NALUs that indicate
that we have already got all the slices belonging to the
current frame.

BUG=370758
TEST=vdatest, stream with AUDs

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269500

[Ami GONE FROM CHROMIUM, 2014-05-08 17:38:30]

LGTM % \noideadog{h.264}.

@acolwell: can you bless this?

[acolwell GONE FROM CHROMIUM, 2014-05-08 17:56:33]

https://codereview.chromium.org/268363018/diff/1/content/common/gpu/media/v4l...
File content/common/gpu/media/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/268363018/diff/1/content/common/gpu/media/v4l...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:655: case
media::H264NALU::kEOSeq:
I think you need to also include kSEIMessage & kReserved14-kReserved18 to this
list. See Section 7.4.1.2.3 of the H.264 spec.

https://codereview.chromium.org/268363018/diff/1/content/common/gpu/media/v4l...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:665: if
(!decoder_partial_frame_pending_ && *endpos == 0) {
I'm a little fuzzy on how this code is supposed to work. Does this properly
identify the sequence {AUD, SPS, PPS, IDRSlice} as a single frame and {IDRSlice,
SPS, PPS, IDRSlice}  as 2 frames?

[Pawel Osciak, 2014-05-09 00:37:13]

https://codereview.chromium.org/268363018/diff/1/content/common/gpu/media/v4l...
File content/common/gpu/media/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/268363018/diff/1/content/common/gpu/media/v4l...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:655: case
media::H264NALU::kEOSeq:
On 2014/05/08 17:56:34, acolwell wrote:
> I think you need to also include kSEIMessage & kReserved14-kReserved18 to this
> list. See Section 7.4.1.2.3 of the H.264 spec.

Oh, I didn't notice you added new defines to the enum yet. Should have noticed
that CL. We could add them here as well then.

By the way, this change doesn't actually fix 370758, but I thought I'd throw
this in since we have it now.

https://codereview.chromium.org/268363018/diff/1/content/common/gpu/media/v4l...
content/common/gpu/media/v4l2_video_decode_accelerator.cc:665: if
(!decoder_partial_frame_pending_ && *endpos == 0) {
On 2014/05/08 17:56:34, acolwell wrote:
> I'm a little fuzzy on how this code is supposed to work. Does this properly
> identify the sequence {AUD, SPS, PPS, IDRSlice} as a single frame and
{IDRSlice,
> SPS, PPS, IDRSlice}  as 2 frames?

It actually splits everything but slices of the same frame. It's too much and I
have a rewrite of this in the works, but it will touch quite a few places in the
class and I didn't want to submit that kind of a change just before branch
point.

[acolwell GONE FROM CHROMIUM, 2014-05-09 01:29:16]

lgtm

[Pawel Osciak, 2014-05-09 01:35:58]

The CQ bit was checked by posciak@chromium.org

[commit-bot: I haz the power, 2014-05-09 01:44:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/posciak@chromium.org/268363018/20001

[commit-bot: I haz the power, 2014-05-10 02:57:59]

Change committed as 269500