Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 268363013: Text selection handles now take into account pinch viewport's offset. (Closed)

Created:
6 years, 7 months ago by bokan
Modified:
6 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Text selection handles now take into account pinch viewport's offset. BUG=364139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173580

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -3 lines) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 5 chunks +48 lines, -0 lines 0 comments Download
A + Source/web/tests/data/pinch-viewport-input-field.html View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bokan
Another quick fix. PTAL
6 years, 7 months ago (2014-05-07 18:44:26 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 7 months ago (2014-05-07 21:37:57 UTC) #2
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 7 months ago (2014-05-07 21:52:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/268363013/20001
6 years, 7 months ago (2014-05-07 21:53:03 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 00:23:43 UTC) #5
Message was sent while issue was closed.
Change committed as 173580

Powered by Google App Engine
This is Rietveld 408576698