Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2683583009: Fix corelib_strong/sort_test on dev_compiler (Closed)

Created:
3 years, 10 months ago by Bill Hesse
Modified:
3 years, 10 months ago
Reviewers:
vsm, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add status file change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/sort_test.dart View 1 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bill Hesse
Do you want to test on DDC?
3 years, 10 months ago (2017-02-08 21:35:03 UTC) #2
Jacob
On 2017/02/08 21:35:03, Bill Hesse wrote: > Do you want to test on DDC? lgtm ...
3 years, 10 months ago (2017-02-08 21:41:25 UTC) #3
vsm
lgtm https://codereview.chromium.org/2683583009/diff/1/tests/corelib_strong/sort_test.dart File tests/corelib_strong/sort_test.dart (right): https://codereview.chromium.org/2683583009/diff/1/tests/corelib_strong/sort_test.dart#newcode10 tests/corelib_strong/sort_test.dart:10: typedef int intPairToInt(int a, int b); drop the ...
3 years, 10 months ago (2017-02-08 22:00:02 UTC) #5
Bill Hesse
Committed patchset #2 (id:20001) manually as 72b58ee3b695c8be138474c5ad40822a6e14c68f (presubmit successful).
3 years, 10 months ago (2017-02-08 22:07:00 UTC) #7
Bill Hesse
3 years, 10 months ago (2017-02-08 22:08:18 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2683583009/diff/1/tests/corelib_strong/sort_t...
File tests/corelib_strong/sort_test.dart (right):

https://codereview.chromium.org/2683583009/diff/1/tests/corelib_strong/sort_t...
tests/corelib_strong/sort_test.dart:10: typedef int intPairToInt(int a, int b);
On 2017/02/08 22:00:02, vsm wrote:
> drop the typedef?

Good catch!

Powered by Google App Engine
This is Rietveld 408576698