Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2683583008: MD Settings: Convert spell-check from checkbox to toggle. (Closed)
Patch Set: Merge branch 'master' into spell-check Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages_page.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index 76147b05e34164593d2635b38b5e130aa8169eef..5e3c1bb8843ae5d9e00750c9443d567fbb34a985 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -65,8 +65,12 @@ Polymer({
* @param {!{target: Element, model: !{item: !LanguageState}}} e
*/
onSpellCheckChange_: function(e) {
- this.languageHelper.toggleSpellCheck(e.model.item.language.code,
- e.target.checked);
+ var item = e.model.item;
+ if (!item.language.supportsSpellcheck)
+ return;
+
+ this.languageHelper.toggleSpellCheck(item.language.code,
+ !item.spellCheckEnabled);
},
/** @private */
« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages_page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698