Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2683583008: MD Settings: Convert spell-check from checkbox to toggle. (Closed)
Patch Set: Another way to implement disabledness Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index 76147b05e34164593d2635b38b5e130aa8169eef..e47eda18bc267ac8a9cb15694ae861b7cb177184 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -65,8 +65,13 @@ Polymer({
* @param {!{target: Element, model: !{item: !LanguageState}}} e
*/
onSpellCheckChange_: function(e) {
- this.languageHelper.toggleSpellCheck(e.model.item.language.code,
- e.target.checked);
+ var item = e.model.item;
+ if(!item.language.supportsSpellcheck) {
Dan Beam 2017/02/09 20:11:19 space after if
scottchen 2017/02/09 21:30:13 Done.
+ return;
+ }
Dan Beam 2017/02/09 20:11:18 no curlies
scottchen 2017/02/09 21:30:13 Done.
+
+ this.languageHelper.toggleSpellCheck(item.language.code,
+ !item.spellCheckEnabled);
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698