Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2683583008: MD Settings: Convert spell-check from checkbox to toggle. (Closed)
Patch Set: Another way to implement disabledness Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/action_link_css.html"> 2 <link rel="import" href="chrome://resources/html/action_link_css.html">
3 <link rel="import" href="chrome://resources/html/assert.html"> 3 <link rel="import" href="chrome://resources/html/assert.html">
4 <link rel="import" href="chrome://resources/html/cr.html"> 4 <link rel="import" href="chrome://resources/html/cr.html">
5 <link rel="import" href="chrome://resources/html/polymer.html"> 5 <link rel="import" href="chrome://resources/html/polymer.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } 59 }
60 60
61 paper-checkbox.dropdown-item { 61 paper-checkbox.dropdown-item {
62 --checkbox-margin-start: 0; 62 --checkbox-margin-start: 0;
63 } 63 }
64 64
65 #uiLanguageItem:focus, 65 #uiLanguageItem:focus,
66 #offerTranslations:focus { 66 #offerTranslations:focus {
67 background-color: transparent; 67 background-color: transparent;
68 } 68 }
69
70 .list-item[actionable][disabled] {
Dan Beam 2017/02/09 20:11:18 i don't think this actually matches anything did
scottchen 2017/02/09 21:30:13 Oops, this was left over from patch#1 where I trie
71 cursor: initial;
72 pointer-events: none;
73 }
69 </style> 74 </style>
70 <settings-languages languages="{{languages}}" prefs="{{prefs}}" 75 <settings-languages languages="{{languages}}" prefs="{{prefs}}"
71 language-helper="{{languageHelper}}"> 76 language-helper="{{languageHelper}}">
72 </settings-languages> 77 </settings-languages>
73 <settings-animated-pages id="pages" section="languages"> 78 <settings-animated-pages id="pages" section="languages">
74 <neon-animatable route-path="default"> 79 <neon-animatable route-path="default">
75 <div class$="settings-box first [[getLanguageListTwoLine_()]]" 80 <div class$="settings-box first [[getLanguageListTwoLine_()]]"
76 actionable on-tap="toggleExpandButton_"> 81 actionable on-tap="toggleExpandButton_">
77 <div class="start"> 82 <div class="start">
78 <div>$i18n{languagesListTitle}</div> 83 <div>$i18n{languagesListTitle}</div>
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 <div>$i18n{spellCheckListTitle}</div> 200 <div>$i18n{spellCheckListTitle}</div>
196 <div class="secondary">[[spellCheckSecondaryText_]]</div> 201 <div class="secondary">[[spellCheckSecondaryText_]]</div>
197 </div> 202 </div>
198 <cr-expand-button expanded="{{spellCheckOpened_}}" 203 <cr-expand-button expanded="{{spellCheckOpened_}}"
199 alt="$i18n{spellCheckExpandA11yLabel}"> 204 alt="$i18n{spellCheckExpandA11yLabel}">
200 </cr-expand-button> 205 </cr-expand-button>
201 </div> 206 </div>
202 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]"> 207 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]">
203 <div class="list-frame vertical-list"> 208 <div class="list-frame vertical-list">
204 <template is="dom-repeat" items="[[languages.enabled]]"> 209 <template is="dom-repeat" items="[[languages.enabled]]">
205 <div class="list-item"> 210 <div class="list-item" on-tap="onSpellCheckChange_"
206 <paper-checkbox 211 actionable$="[[item.language.supportsSpellcheck]]">
207 checked="[[item.spellCheckEnabled]]" 212 <div class="start">[[item.language.displayName]]</div>
208 on-change="onSpellCheckChange_" 213 <paper-toggle-button
209 disabled$="[[!item.language.supportsSpellcheck]]"> 214 disabled="[[!item.language.supportsSpellcheck]]"
210 [[item.language.displayName]] 215 checked="[[item.spellCheckEnabled]]">
211 </paper-checkbox> 216 </paper-toggle-button>
212 </label> 217 </div>
213 </template> 218 </template>
214 <div class="list-item"> 219 <div class="list-item">
215 <a is="action-link" class="list-button" 220 <a is="action-link" class="list-button"
216 on-tap="onEditDictionaryTap_"> 221 on-tap="onEditDictionaryTap_">
217 $i18n{manageSpellCheck} 222 $i18n{manageSpellCheck}
218 </a> 223 </a>
219 </div> 224 </div>
220 </div> 225 </div>
221 </iron-collapse> 226 </iron-collapse>
222 </if> 227 </if>
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 </if> 295 </if>
291 </settings-animated-pages> 296 </settings-animated-pages>
292 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 297 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
293 <settings-add-languages-dialog languages="{{languages}}" 298 <settings-add-languages-dialog languages="{{languages}}"
294 language-helper="[[languageHelper]]"> 299 language-helper="[[languageHelper]]">
295 </settings-add-languages-dialog> 300 </settings-add-languages-dialog>
296 </template> 301 </template>
297 </template> 302 </template>
298 <script src="languages_page.js"></script> 303 <script src="languages_page.js"></script>
299 </dom-module> 304 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698