Move display_ From CompositorFrameSinkSupport To GpuDisplayCompositorFrameSink

services/ui/ws/frame_generator.cc

Index: services/ui/ws/frame_generator.cc
diff --git a/services/ui/ws/frame_generator.cc b/services/ui/ws/frame_generator.cc
index 4a7809f0adcbc91673f17ed352265627926b68e5..8ea32bd58816a7e2f6d1655f1251b1df3742652b 100644
--- a/services/ui/ws/frame_generator.cc
+++ b/services/ui/ws/frame_generator.cc
@@ -89,6 +89,8 @@ void FrameGenerator::OnBeginFrame(const cc::BeginFrameArgs& begin_frame_arags) {
     if (!local_surface_id_.is_valid() ||
         frame_size != last_submitted_frame_size_) {
       local_surface_id_ = id_allocator_.GenerateId();
+      display_private_->SetLocalSurfaceId(local_surface_id_,

[danakj, 2017/02/08 21:54:40]

DirectCompositorFrameSink::SubmitCompositorFrame doesn't do this only when the
size changes. Why the inconsistency?

[Alex Z., 2017/02/08 22:07:52]

I wanted to only do this when local surface id changes.
I'll move it out to be consistent with DirectCompositorFrameSink.

[danakj, 2017/02/08 23:31:16]

Well.. we shouldn't do work we don't need to but I want to understand what is
different here. Why does DirectCompositorFrameSink need to do this when resize
didn't happen but this doesn't? We can document this with comments.

[Alex Z., 2017/02/10 19:44:35]

Display::SetLocalSurfaceId() checks at the beginning and early 
returns if neither local_surface_id_ nor device_scale_factor_ has
changed.

+                                          frame.metadata.device_scale_factor);
       display_private_->ResizeDisplay(frame_size);
     }