Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: cc/surfaces/compositor_frame_sink_support.cc

Issue 2683583005: Move display_ From CompositorFrameSinkSupport To GpuDisplayCompositorFrameSink (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/compositor_frame_sink_support.h" 5 #include "cc/surfaces/compositor_frame_sink_support.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
11 #include "cc/output/compositor_frame.h" 11 #include "cc/output/compositor_frame.h"
12 #include "cc/scheduler/begin_frame_source.h" 12 #include "cc/scheduler/begin_frame_source.h"
13 #include "cc/surfaces/compositor_frame_sink_support_client.h" 13 #include "cc/surfaces/compositor_frame_sink_support_client.h"
14 #include "cc/surfaces/display.h" 14 #include "cc/surfaces/display.h"
15 #include "cc/surfaces/surface.h" 15 #include "cc/surfaces/surface.h"
16 #include "cc/surfaces/surface_manager.h" 16 #include "cc/surfaces/surface_manager.h"
17 #include "cc/surfaces/surface_reference.h" 17 #include "cc/surfaces/surface_reference.h"
18 18
19 namespace cc { 19 namespace cc {
20 20
21 CompositorFrameSinkSupport::CompositorFrameSinkSupport( 21 CompositorFrameSinkSupport::CompositorFrameSinkSupport(
22 CompositorFrameSinkSupportClient* client, 22 CompositorFrameSinkSupportClient* client,
23 SurfaceManager* surface_manager, 23 SurfaceManager* surface_manager,
24 const FrameSinkId& frame_sink_id, 24 const FrameSinkId& frame_sink_id,
25 std::unique_ptr<Display> display, 25 bool submits_to_display_compositor)
26 std::unique_ptr<BeginFrameSource> display_begin_frame_source)
27 : client_(client), 26 : client_(client),
28 surface_manager_(surface_manager), 27 surface_manager_(surface_manager),
29 frame_sink_id_(frame_sink_id), 28 frame_sink_id_(frame_sink_id),
30 display_begin_frame_source_(std::move(display_begin_frame_source)),
31 display_(std::move(display)),
32 surface_factory_(frame_sink_id_, surface_manager_, this), 29 surface_factory_(frame_sink_id_, surface_manager_, this),
33 reference_tracker_(frame_sink_id), 30 reference_tracker_(frame_sink_id),
31 submits_to_display_compositor_(submits_to_display_compositor),
34 weak_factory_(this) { 32 weak_factory_(this) {
35 surface_manager_->RegisterFrameSinkId(frame_sink_id_); 33 surface_manager_->RegisterFrameSinkId(frame_sink_id_);
36 surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this); 34 surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this);
37
38 if (display_) {
39 display_->Initialize(this, surface_manager_);
40 display_->SetVisible(true);
41 }
42 } 35 }
43 36
44 CompositorFrameSinkSupport::~CompositorFrameSinkSupport() { 37 CompositorFrameSinkSupport::~CompositorFrameSinkSupport() {
45 // For display root surfaces, the surface is no longer going to be visible 38 // For display root surfaces, the surface is no longer going to be visible
46 // so make it unreachable from the top-level root. 39 // so make it unreachable from the top-level root.
47 if (surface_manager_->using_surface_references() && display_ && 40 if (surface_manager_->using_surface_references() &&
41 submits_to_display_compositor_ &&
48 reference_tracker_.current_surface_id().is_valid()) 42 reference_tracker_.current_surface_id().is_valid())
49 RemoveTopLevelRootReference(reference_tracker_.current_surface_id()); 43 RemoveTopLevelRootReference(reference_tracker_.current_surface_id());
50 44
51 for (auto& child_frame_sink_id : child_frame_sinks_) { 45 for (auto& child_frame_sink_id : child_frame_sinks_) {
52 DCHECK(child_frame_sink_id.is_valid()); 46 DCHECK(child_frame_sink_id.is_valid());
53 surface_manager_->UnregisterFrameSinkHierarchy(frame_sink_id_, 47 surface_manager_->UnregisterFrameSinkHierarchy(frame_sink_id_,
54 child_frame_sink_id); 48 child_frame_sink_id);
55 } 49 }
56 // SurfaceFactory's destructor will attempt to return resources which will 50 // SurfaceFactory's destructor will attempt to return resources which will
57 // call back into here and access |client_| so we should destroy 51 // call back into here and access |client_| so we should destroy
58 // |surface_factory_|'s resources early on. 52 // |surface_factory_|'s resources early on.
59 surface_factory_.EvictSurface(); 53 surface_factory_.EvictSurface();
60 surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_); 54 surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_);
61 surface_manager_->InvalidateFrameSinkId(frame_sink_id_); 55 surface_manager_->InvalidateFrameSinkId(frame_sink_id_);
62 } 56 }
63 57
64 void CompositorFrameSinkSupport::EvictFrame() { 58 void CompositorFrameSinkSupport::EvictFrame() {
65 surface_factory_.EvictSurface(); 59 surface_factory_.EvictSurface();
66 } 60 }
67 61
68 void CompositorFrameSinkSupport::SetNeedsBeginFrame(bool needs_begin_frame) { 62 void CompositorFrameSinkSupport::SetNeedsBeginFrame(bool needs_begin_frame) {
69 needs_begin_frame_ = needs_begin_frame; 63 needs_begin_frame_ = needs_begin_frame;
70 UpdateNeedsBeginFramesInternal(); 64 UpdateNeedsBeginFramesInternal();
71 } 65 }
72 66
73 void CompositorFrameSinkSupport::SubmitCompositorFrame( 67 void CompositorFrameSinkSupport::SubmitCompositorFrame(
74 const LocalSurfaceId& local_surface_id, 68 const LocalSurfaceId& local_surface_id,
75 CompositorFrame frame) { 69 CompositorFrame frame) {
76 ++ack_pending_count_; 70 ++ack_pending_count_;
77 float device_scale_factor = frame.metadata.device_scale_factor;
78 71
79 surface_factory_.SubmitCompositorFrame( 72 surface_factory_.SubmitCompositorFrame(
80 local_surface_id, std::move(frame), 73 local_surface_id, std::move(frame),
81 base::Bind(&CompositorFrameSinkSupport::DidReceiveCompositorFrameAck, 74 base::Bind(&CompositorFrameSinkSupport::DidReceiveCompositorFrameAck,
82 weak_factory_.GetWeakPtr())); 75 weak_factory_.GetWeakPtr()));
83 76
84 if (surface_manager_->using_surface_references()) { 77 if (surface_manager_->using_surface_references()) {
85 SurfaceId last_surface_id = reference_tracker_.current_surface_id(); 78 SurfaceId last_surface_id = reference_tracker_.current_surface_id();
86 79
87 // Populate list of surface references to add and remove based on reference 80 // Populate list of surface references to add and remove based on reference
(...skipping 10 matching lines...) Expand all
98 std::vector<SurfaceId> referenced_surfaces = 91 std::vector<SurfaceId> referenced_surfaces =
99 surface->active_referenced_surfaces(); 92 surface->active_referenced_surfaces();
100 93
101 referenced_surfaces.insert(referenced_surfaces.end(), 94 referenced_surfaces.insert(referenced_surfaces.end(),
102 surface->pending_referenced_surfaces().begin(), 95 surface->pending_referenced_surfaces().begin(),
103 surface->pending_referenced_surfaces().end()); 96 surface->pending_referenced_surfaces().end());
104 reference_tracker_.UpdateReferences(local_surface_id, referenced_surfaces); 97 reference_tracker_.UpdateReferences(local_surface_id, referenced_surfaces);
105 98
106 UpdateSurfaceReferences(last_surface_id, local_surface_id); 99 UpdateSurfaceReferences(last_surface_id, local_surface_id);
107 } 100 }
108
109 if (display_)
110 display_->SetLocalSurfaceId(local_surface_id, device_scale_factor);
111 } 101 }
112 102
113 void CompositorFrameSinkSupport::Require(const LocalSurfaceId& local_surface_id, 103 void CompositorFrameSinkSupport::Require(const LocalSurfaceId& local_surface_id,
114 const SurfaceSequence& sequence) { 104 const SurfaceSequence& sequence) {
115 surface_manager_->RequireSequence(SurfaceId(frame_sink_id_, local_surface_id), 105 surface_manager_->RequireSequence(SurfaceId(frame_sink_id_, local_surface_id),
116 sequence); 106 sequence);
117 } 107 }
118 108
119 void CompositorFrameSinkSupport::Satisfy(const SurfaceSequence& sequence) { 109 void CompositorFrameSinkSupport::Satisfy(const SurfaceSequence& sequence) {
120 surface_manager_->SatisfySequence(sequence); 110 surface_manager_->SatisfySequence(sequence);
121 } 111 }
122 112
123 void CompositorFrameSinkSupport::UpdateSurfaceReferences( 113 void CompositorFrameSinkSupport::UpdateSurfaceReferences(
124 const SurfaceId& last_surface_id, 114 const SurfaceId& last_surface_id,
125 const LocalSurfaceId& local_surface_id) { 115 const LocalSurfaceId& local_surface_id) {
126 const bool surface_id_changed = 116 const bool surface_id_changed =
127 last_surface_id.local_surface_id() != local_surface_id; 117 last_surface_id.local_surface_id() != local_surface_id;
128 118
129 // If this is a display root surface and the SurfaceId is changing, make the 119 // If this is a display root surface and the SurfaceId is changing, make the
130 // new SurfaceId reachable from the top-level root. 120 // new SurfaceId reachable from the top-level root.
131 if (display_ && surface_id_changed) 121 if (submits_to_display_compositor_ && surface_id_changed)
132 AddTopLevelRootReference(reference_tracker_.current_surface_id()); 122 AddTopLevelRootReference(reference_tracker_.current_surface_id());
133 123
134 // Add references based on CompositorFrame referenced surfaces. If the 124 // Add references based on CompositorFrame referenced surfaces. If the
135 // SurfaceId has changed all referenced surfaces will be in this list. 125 // SurfaceId has changed all referenced surfaces will be in this list.
136 if (!reference_tracker_.references_to_add().empty()) { 126 if (!reference_tracker_.references_to_add().empty()) {
137 surface_manager_->AddSurfaceReferences( 127 surface_manager_->AddSurfaceReferences(
138 reference_tracker_.references_to_add()); 128 reference_tracker_.references_to_add());
139 } 129 }
140 130
141 // If this is a display root surface and the SurfaceId is changing, make the 131 // If this is a display root surface and the SurfaceId is changing, make the
142 // old SurfaceId unreachable from the top-level root. This needs to happen 132 // old SurfaceId unreachable from the top-level root. This needs to happen
143 // after adding all references for the new SurfaceId. 133 // after adding all references for the new SurfaceId.
144 if (display_ && surface_id_changed && last_surface_id.is_valid()) 134 if (submits_to_display_compositor_ && surface_id_changed &&
135 last_surface_id.is_valid())
145 RemoveTopLevelRootReference(last_surface_id); 136 RemoveTopLevelRootReference(last_surface_id);
146 137
147 // Remove references based on CompositorFrame referenced surfaces. If the 138 // Remove references based on CompositorFrame referenced surfaces. If the
148 // SurfaceId has changed this list will be empty. 139 // SurfaceId has changed this list will be empty.
149 if (!reference_tracker_.references_to_remove().empty()) { 140 if (!reference_tracker_.references_to_remove().empty()) {
150 DCHECK(!surface_id_changed); 141 DCHECK(!surface_id_changed);
151 surface_manager_->RemoveSurfaceReferences( 142 surface_manager_->RemoveSurfaceReferences(
152 reference_tracker_.references_to_remove()); 143 reference_tracker_.references_to_remove());
153 } 144 }
154 } 145 }
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 void CompositorFrameSinkSupport::RemoveChildFrameSink( 179 void CompositorFrameSinkSupport::RemoveChildFrameSink(
189 const FrameSinkId& child_frame_sink_id) { 180 const FrameSinkId& child_frame_sink_id) {
190 auto it = child_frame_sinks_.find(child_frame_sink_id); 181 auto it = child_frame_sinks_.find(child_frame_sink_id);
191 DCHECK(it != child_frame_sinks_.end()); 182 DCHECK(it != child_frame_sinks_.end());
192 DCHECK(it->is_valid()); 183 DCHECK(it->is_valid());
193 surface_manager_->UnregisterFrameSinkHierarchy(frame_sink_id_, 184 surface_manager_->UnregisterFrameSinkHierarchy(frame_sink_id_,
194 child_frame_sink_id); 185 child_frame_sink_id);
195 child_frame_sinks_.erase(it); 186 child_frame_sinks_.erase(it);
196 } 187 }
197 188
198 void CompositorFrameSinkSupport::DisplayOutputSurfaceLost() {}
199
200 void CompositorFrameSinkSupport::DisplayWillDrawAndSwap(
201 bool will_draw_and_swap,
202 const RenderPassList& render_passes) {}
203
204 void CompositorFrameSinkSupport::DisplayDidDrawAndSwap() {}
205
206 void CompositorFrameSinkSupport::ReturnResources( 189 void CompositorFrameSinkSupport::ReturnResources(
207 const ReturnedResourceArray& resources) { 190 const ReturnedResourceArray& resources) {
208 if (resources.empty()) 191 if (resources.empty())
209 return; 192 return;
210 193
211 if (!ack_pending_count_ && client_) { 194 if (!ack_pending_count_ && client_) {
212 client_->ReclaimResources(resources); 195 client_->ReclaimResources(resources);
213 return; 196 return;
214 } 197 }
215 198
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 return; 239 return;
257 240
258 added_frame_observer_ = needs_begin_frame_; 241 added_frame_observer_ = needs_begin_frame_;
259 if (needs_begin_frame_) 242 if (needs_begin_frame_)
260 begin_frame_source_->AddObserver(this); 243 begin_frame_source_->AddObserver(this);
261 else 244 else
262 begin_frame_source_->RemoveObserver(this); 245 begin_frame_source_->RemoveObserver(this);
263 } 246 }
264 247
265 } // namespace cc 248 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/compositor_frame_sink_support.h ('k') | cc/surfaces/compositor_frame_sink_support_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698