[parser] Skipping inner funcs: produce the same scopes / variables for this expressions.

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 9240 matching lines @@
       {"", "var var1; var var1; function f() { var1 = 5; }"},
 
       // Shadowing declarations.
       {"", "var var1; if (true) { var var1; }"},
       {"", "var var1; if (true) { let var1; }"},
       {"", "let var1; if (true) { let var1; }"},
 
       {"", "var var1; if (true) { const var1 = 0; }"},
       {"", "const var1 = 0; if (true) { const var1 = 0; }"},
 
-      // Variable called "arguments"
+      // Arguments and this.
       {"", "arguments;"},
       {"", "arguments = 5;"},
+      {"", "if (true) { arguments; }"},
+      {"", "if (true) { arguments = 5; }"},
       {"", "function f() { arguments; }"},
       {"", "function f() { arguments = 5; }"},
 
+      {"", "this;"},
+      {"", "this = 5;"},
+      {"", "if (true) { this; }"},
+      {"", "if (true) { this = 5; }"},
+      {"", "function f() { this; }"},
+      {"", "function f() { this = 5; }"},
+
+      // Variable called "arguments"
       {"", "var arguments;"},
       {"", "var arguments; arguments = 5;"},
       {"", "if (true) { var arguments; }"},
       {"", "if (true) { var arguments; arguments = 5; }"},
       {"", "var arguments; function f() { arguments; }"},
       {"", "var arguments; arguments = 5; function f() { arguments; }"},
       {"", "var arguments; function f() { arguments = 5; }"},
 
       {"", "let arguments;"},
       {"", "let arguments; arguments = 5;"},
@@ skipping 151 matching lines @@
 
       {"", "var var1 = 0; for(var1; var1 < 2; ++var1) { }"},
       {"",
        "var var1 = 0; for (var1; var1 < 2; ++var1) { function foo() { var1; } "
        "}"},
       {"", "var var1 = 0; for (var1; var1 > 2; ) { }"},
       {"", "var var1 = 0; for (var1; var1 > 2; ) { function foo() { var1; } }"},
       {"",
        "var var1 = 0; for (var1; var1 > 2; ) { function foo() { var1 = 6; } }"},
 
-      // FIXME(marja): Add test cases for special variables (this, arguments

[marja, 2017/02/07 08:23:16]

This was a red herring; turns out this expressions didn't work at all, unrelated
to loops. So I added tests above.

[vogelheim, 2017/02/07 08:33:47]

Acknowledged.

-      // etc) referred to in the for loop conditions.
-
       // Sloppy block functions.
       {"", "if (true) { function f1() {} }"},
       {"", "if (true) { function f1() {} function f1() {} }"},
       {"", "if (true) { if (true) { function f1() {} } }"},
       {"", "if (true) { if (true) { function f1() {} function f1() {} } }"},
       {"", "if (true) { function f1() {} f1 = 3; }"},
 
       {"", "if (true) { function f1() {} function foo() { f1; } }"},
       {"", "if (true) { function f1() {} } function foo() { f1; }"},
       {"",
@@ skipping 77 matching lines @@
         eager_info.literal()->scope()->inner_scope()->inner_scope();
     DCHECK_NOT_NULL(scope);
     DCHECK_NULL(scope->sibling());
     DCHECK(scope->is_function_scope());
 
     size_t index = 0;
     i::ScopeTestHelper::CompareScopeToData(
         scope, lazy_info.preparsed_scope_data(), index);
   }
 }