Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/WebKit/Source/core/layout/TextAutosizer.cpp

Issue 2683553002: Fix not autosizing ruby elements issue. (Closed)
Patch Set: cr Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/TextAutosizer.cpp
diff --git a/third_party/WebKit/Source/core/layout/TextAutosizer.cpp b/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
index af61f4ee062355a2a97ee95ee8ea791af24cea91..0222e18b121cd95db43a0eca41927a69a16bfc26 100644
--- a/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
+++ b/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
@@ -30,6 +30,7 @@
#include "core/layout/TextAutosizer.h"
+#include <memory>
#include "core/dom/Document.h"
#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
@@ -41,6 +42,7 @@
#include "core/layout/LayoutInline.h"
#include "core/layout/LayoutListItem.h"
#include "core/layout/LayoutListMarker.h"
+#include "core/layout/LayoutRubyRun.h"
#include "core/layout/LayoutTable.h"
#include "core/layout/LayoutTableCell.h"
#include "core/layout/LayoutView.h"
@@ -48,7 +50,6 @@
#include "core/layout/api/LayoutViewItem.h"
#include "core/page/Page.h"
#include "wtf/PtrUtil.h"
-#include <memory>
#ifdef AUTOSIZING_DOM_DEBUG_INFO
#include "core/dom/ExecutionContextTask.h"
@@ -400,6 +401,10 @@ void TextAutosizer::beginLayout(LayoutBlock* block,
if (prepareForLayout(block) == StopLayout)
return;
+ // Skip ruby's inner blocks, because these blocks already are inflated.
+ if (block->isRubyRun() || block->isRubyBase() || block->isRubyText())
+ return;
+
ASSERT(!m_clusterStack.isEmpty() || block->isLayoutView());
if (Cluster* cluster = maybeCreateCluster(block))
@@ -470,11 +475,20 @@ float TextAutosizer::inflate(LayoutObject* parent,
bool hasTextChild = false;
LayoutObject* child = nullptr;
- if (parent->isLayoutBlock() &&
- (parent->childrenInline() || behavior == DescendToInnerBlocks))
+ if (parent->isRuby()) {
+ // Skip layoutRubyRun which is inline-block.
+ // Inflate rubyRun's inner blocks.
+ LayoutObject* run = parent->slowFirstChild();
+ if (run && run->isRubyRun()) {
+ child = toLayoutRubyRun(run)->firstChild();
+ behavior = DescendToInnerBlocks;
+ }
+ } else if (parent->isLayoutBlock() &&
+ (parent->childrenInline() || behavior == DescendToInnerBlocks)) {
child = toLayoutBlock(parent)->firstChild();
- else if (parent->isLayoutInline())
+ } else if (parent->isLayoutInline()) {
child = toLayoutInline(parent)->firstChild();
+ }
while (child) {
if (child->isText()) {
@@ -486,9 +500,14 @@ float TextAutosizer::inflate(LayoutObject* parent,
cluster->m_flags & SUPPRESSING ? 1.0f : clusterMultiplier(cluster);
applyMultiplier(child, multiplier, layouter);
- // FIXME: Investigate why MarkOnlyThis is sufficient.
- if (parent->isLayoutInline())
+ if (behavior == DescendToInnerBlocks) {
+ // The ancestor nodes might be inline-blocks. We should
+ // setPreferredLogicalWidthsDirty for ancestor nodes here.
+ child->setPreferredLogicalWidthsDirty();
+ } else if (parent->isLayoutInline()) {
+ // FIXME: Investigate why MarkOnlyThis is sufficient.
child->setPreferredLogicalWidthsDirty(MarkOnlyThis);
+ }
} else if (child->isLayoutInline()) {
multiplier = inflate(child, layouter, behavior, multiplier);
} else if (child->isLayoutBlock() && behavior == DescendToInnerBlocks &&
@@ -1173,6 +1192,8 @@ void TextAutosizer::applyMultiplier(LayoutObject* layoutObject,
m_stylesRetainedDuringLayout.push_back(&currentStyle);
layoutObject->setStyleInternal(std::move(style));
+ if (layoutObject->isText())
+ toLayoutText(layoutObject)->autosizingMultiplerChanged();
DCHECK(!layouter || layoutObject->isDescendantOf(&layouter->root()));
layoutObject->setNeedsLayoutAndFullPaintInvalidation(
LayoutInvalidationReason::TextAutosizing, MarkContainerChain,
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.h ('k') | third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698