Issue 2683543006: Make some parser test helper methods non-static.

Issue 2683543006: Make some parser test helper methods non-static. (Closed)

Created:
3 years, 10 months ago by Paul Berry

Modified:
3 years, 10 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Make some parser test helper methods non-static. This paves the way for allowing more of analyzer's parser tests to be run on both Fasta's parser and the analyzer parser. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/67463b0f7dfcd7f6e09c34bca9a25f9c4586621c

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+304 lines, -282 lines)			Patch
M	pkg/analyzer/test/dart/ast/visitor_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/dart/element/builder_test.dart	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_fasta_test.dart	View	7 chunks	+46 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	88 chunks	+226 lines, -247 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	8 chunks	+13 lines, -11 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/analysis/defined_names_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/analysis/referenced_names_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/ast/utilities_test.dart	View	5 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 6 (2 generated)

Paul Berry

3 years, 10 months ago (2017-02-08 16:25:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
67463b0f7dfcd7f6e09c34bca9a25f9c4586621c (presubmit successful).