Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: services/service_manager/public/cpp/lib/service_runner.cc

Issue 2683543003: Fix shutdown crash by ensuring valid MessageLoop (Closed)
Patch Set: Delete commented out code. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/public/cpp/lib/service_runner.cc
diff --git a/services/service_manager/public/cpp/lib/service_runner.cc b/services/service_manager/public/cpp/lib/service_runner.cc
index 99e1130ff53062d616b2b24490b8d33d3894539b..374a9483ca2416a4237a8cee6db957951a6be308 100644
--- a/services/service_manager/public/cpp/lib/service_runner.cc
+++ b/services/service_manager/public/cpp/lib/service_runner.cc
@@ -59,13 +59,6 @@ MojoResult ServiceRunner::Run(MojoHandle service_request_handle,
base::RunLoop run_loop;
context_->SetConnectionLostClosure(run_loop.QuitClosure());
run_loop.Run();
- // It's very common for the service to cache the app and terminate on
- // errors. If we don't delete the service before the app we run the risk of
- // the service having a stale reference to the app and trying to use it.
- // Note that we destruct the message loop first because that might trigger
- // connection error handlers and they might access objects created by the
- // service.
- loop.reset();
context_.reset();
}
return MOJO_RESULT_OK;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698