Source/modules/notifications/NotificationController.h - Issue 268353004: NotificationController::clientFrom() should return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/NotificationController.h

Issue 268353004: NotificationController::clientFrom() should return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/notifications/Notification.cpp ('K') | « Source/modules/notifications/Notification.cpp ('k') | Source/modules/notifications/NotificationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/NotificationController.h

diff --git a/Source/modules/notifications/NotificationController.h b/Source/modules/notifications/NotificationController.h

index d2dee1cc2db7e1b8b3094809b005bcf4feed2213..ef72f07140de5286fd9679eeda2f8cb5d5e0db24 100644

--- a/Source/modules/notifications/NotificationController.h

+++ b/Source/modules/notifications/NotificationController.h

@@ -42,9 +42,9 @@ public:

static PassOwnPtr<NotificationController> create(PassOwnPtr<NotificationClient>);

static const char* supplementName();

static NotificationController* from(LocalFrame* frame) { return static_cast<NotificationController*>(Supplement<LocalFrame>::from(frame, supplementName())); }

- static NotificationClient* clientFrom(LocalFrame*);

+ static NotificationClient& clientFrom(LocalFrame*);

- NotificationClient* client() { return m_client.get(); }

+ NotificationClient& client() { return *m_client; }

virtual void trace(Visitor* visitor) OVERRIDE { Supplement<LocalFrame>::trace(visitor); }