Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: Source/modules/notifications/NotificationController.h

Issue 268353004: NotificationController::clientFrom() should return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 24 matching lines...) Expand all
35 class NotificationClient; 35 class NotificationClient;
36 36
37 class NotificationController FINAL : public Supplement<LocalFrame> { 37 class NotificationController FINAL : public Supplement<LocalFrame> {
38 WTF_MAKE_NONCOPYABLE(NotificationController); 38 WTF_MAKE_NONCOPYABLE(NotificationController);
39 public: 39 public:
40 virtual ~NotificationController(); 40 virtual ~NotificationController();
41 41
42 static PassOwnPtr<NotificationController> create(PassOwnPtr<NotificationClie nt>); 42 static PassOwnPtr<NotificationController> create(PassOwnPtr<NotificationClie nt>);
43 static const char* supplementName(); 43 static const char* supplementName();
44 static NotificationController* from(LocalFrame* frame) { return static_cast< NotificationController*>(Supplement<LocalFrame>::from(frame, supplementName())); } 44 static NotificationController* from(LocalFrame* frame) { return static_cast< NotificationController*>(Supplement<LocalFrame>::from(frame, supplementName())); }
45 static NotificationClient* clientFrom(LocalFrame*); 45 static NotificationClient& clientFrom(LocalFrame*);
46
47 NotificationClient* client() { return m_client.get(); }
48 46
49 virtual void trace(Visitor* visitor) OVERRIDE { Supplement<LocalFrame>::trac e(visitor); } 47 virtual void trace(Visitor* visitor) OVERRIDE { Supplement<LocalFrame>::trac e(visitor); }
50 48
51 private: 49 private:
52 explicit NotificationController(PassOwnPtr<NotificationClient>); 50 explicit NotificationController(PassOwnPtr<NotificationClient>);
53 51
52 NotificationClient& client() { return *m_client; }
53
54 OwnPtr<NotificationClient> m_client; 54 OwnPtr<NotificationClient> m_client;
55 }; 55 };
56 56
57 void provideNotification(LocalFrame&, PassOwnPtr<NotificationClient>); 57 void provideNotification(LocalFrame&, PassOwnPtr<NotificationClient>);
58 58
59 } // namespace WebCore 59 } // namespace WebCore
60 60
61 #endif // NotificationController_h 61 #endif // NotificationController_h
OLDNEW
« no previous file with comments | « Source/modules/notifications/Notification.cpp ('k') | Source/modules/notifications/NotificationController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698