Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Side by Side Diff: Source/modules/notifications/NotificationController.cpp

Issue 268353004: NotificationController::clientFrom() should return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/notifications/NotificationController.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 27 matching lines...) Expand all
38 38
39 NotificationController::~NotificationController() 39 NotificationController::~NotificationController()
40 { 40 {
41 } 41 }
42 42
43 PassOwnPtr<NotificationController> NotificationController::create(PassOwnPtr<Not ificationClient> client) 43 PassOwnPtr<NotificationController> NotificationController::create(PassOwnPtr<Not ificationClient> client)
44 { 44 {
45 return adoptPtr(new NotificationController(client)); 45 return adoptPtr(new NotificationController(client));
46 } 46 }
47 47
48 NotificationClient* NotificationController::clientFrom(LocalFrame* frame) 48 NotificationClient& NotificationController::clientFrom(LocalFrame* frame)
49 { 49 {
50 if (NotificationController* controller = NotificationController::from(frame) ) 50 NotificationController* controller = NotificationController::from(frame);
51 return controller->client(); 51 ASSERT(controller);
52 return 0; 52 return controller->client();
53 } 53 }
54 54
55 const char* NotificationController::supplementName() 55 const char* NotificationController::supplementName()
56 { 56 {
57 return "NotificationController"; 57 return "NotificationController";
58 } 58 }
59 59
60 void provideNotification(LocalFrame& frame, PassOwnPtr<NotificationClient> clien t) 60 void provideNotification(LocalFrame& frame, PassOwnPtr<NotificationClient> clien t)
61 { 61 {
62 NotificationController::provideTo(frame, NotificationController::supplementN ame(), NotificationController::create(client)); 62 NotificationController::provideTo(frame, NotificationController::supplementN ame(), NotificationController::create(client));
63 } 63 }
64 64
65 } // namespace WebCore 65 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/notifications/NotificationController.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698