components/offline_pages/core/offline_page_test_archiver.cc - Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/offline_page_test_archiver.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)

Patch Set: FIx tests, add unit test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/core/offline_page_test_archiver.cc

diff --git a/components/offline_pages/core/offline_page_test_archiver.cc b/components/offline_pages/core/offline_page_test_archiver.cc

index 145e5acbbe2d054bb7f8358ccee731f3d4e684c1..9563f9b63e3bb12d74305f9cd3bc1584fb9c7886 100644

--- a/components/offline_pages/core/offline_page_test_archiver.cc

+++ b/components/offline_pages/core/offline_page_test_archiver.cc

@@ -35,6 +35,7 @@ OfflinePageTestArchiver::~OfflinePageTestArchiver() {

void OfflinePageTestArchiver::CreateArchive(

const base::FilePath& archives_dir,

const CreateArchiveParams& create_archive_params,

+ const std::string& signal_data,

const CreateArchiveCallback& callback) {

create_archive_called_ = true;

callback_ = callback;