components/offline_pages/core/offline_page_model_impl.h - Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/offline_page_model_impl.h

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)

Patch Set: FIx tests, add unit test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/core/offline_page_model_impl.h

diff --git a/components/offline_pages/core/offline_page_model_impl.h b/components/offline_pages/core/offline_page_model_impl.h

index 5221644d7f3d51c391db613c688abba26dbe7a3b..0c44e01f52e250d7b066febd95fa620429c892a0 100644

--- a/components/offline_pages/core/offline_page_model_impl.h

+++ b/components/offline_pages/core/offline_page_model_impl.h

@@ -66,6 +66,7 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {

void RemoveObserver(Observer* observer) override;

void SavePage(const SavePageParams& save_page_params,

std::unique_ptr<OfflinePageArchiver> archiver,

+ const std::string& signal_data,

const SavePageCallback& callback) override;

void MarkPageAccessed(int64_t offline_id) override;

void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,