Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: content/browser/download/mhtml_extra_parts_impl.h

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: CR feedback per Dimich Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/mhtml_extra_parts_impl.h
diff --git a/content/browser/download/mhtml_extra_parts_impl.h b/content/browser/download/mhtml_extra_parts_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..0822644ac85e16e502ea277276dbaa07e8e78d54
--- /dev/null
+++ b/content/browser/download/mhtml_extra_parts_impl.h
@@ -0,0 +1,45 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_DOWNLOAD_MHTML_EXTRA_PARTS_IMPL_H_
+#define CONTENT_BROWSER_DOWNLOAD_MHTML_EXTRA_PARTS_IMPL_H_
+
+#include "content/public/browser/mhtml_extra_parts.h"
+
+namespace content {
+
+// Data fields used to build an additional MHTML part in the output file.
+struct MHTMLExtraDataPart {
+ std::string content_type;
+ std::string content_location;
+ std::string body;
+};
+
+// Class used as a data object for WebContents UserData to represent a MHTML
+// part that we plan to write into the output MHTML file. Each MHTMLExtraPart
+// object in the contained vector lets us hold enough information to generate
+// one MHTML part. This allows arbitrary extra MHTML parts to be added into the
+// complete file. For instance, this might be used for gathering load time
+// signals in debug code for analysis.
+class MHTMLExtraPartsImpl : public content::MHTMLExtraParts {
+ public:
+ MHTMLExtraPartsImpl();
+ ~MHTMLExtraPartsImpl() override;
+
+ // Return the vector of parts to be serialized.
+ std::vector<MHTMLExtraDataPart>& parts() { return parts_; }
Dmitry Titov 2017/03/29 23:26:29 It's weird to have both methods like this. There s
Pete Williamson 2017/03/31 00:29:49 The test needs the writeable version of parts(), s
Dmitry Titov 2017/03/31 18:05:53 What test is using it? I don't see.
Pete Williamson 2017/03/31 21:58:03 Ah, sorry, it looks like that test got refactored
+ const std::vector<MHTMLExtraDataPart>& parts() const { return parts_; }
+
+ // Creates a MHTMLExtraDataPart and adds it to our vector of parts.
+ void AddExtraMHTMLPart(const std::string& content_type,
+ const std::string& content_location,
+ const std::string& body) override;
+
+ private:
+ std::vector<MHTMLExtraDataPart> parts_;
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_DOWNLOAD_MHTML_EXTRA_PARTS_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698