Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: components/offline_pages/core/offline_page_model_impl_unittest.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: Approach for writing to the file afterwards instead. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/offline_page_model_impl_unittest.cc
diff --git a/components/offline_pages/core/offline_page_model_impl_unittest.cc b/components/offline_pages/core/offline_page_model_impl_unittest.cc
index b5806b222b7a343c8cf21ba5e3c43916eff73ef0..8327e09c0edfd18fb5e7352fe222a98a31356ecc 100644
--- a/components/offline_pages/core/offline_page_model_impl_unittest.cc
+++ b/components/offline_pages/core/offline_page_model_impl_unittest.cc
@@ -86,7 +86,9 @@ class OfflinePageModelImplTest
void SetLastPathCreatedByArchiver(const base::FilePath& file_path) override;
// OfflinePageModel callbacks.
- void OnSavePageDone(SavePageResult result, int64_t offline_id);
+ void OnSavePageDone(SavePageResult result,
+ int64_t offline_id,
+ const base::FilePath& saved_filepath);
void OnDeletePageDone(DeletePageResult result);
void OnCheckPagesExistOfflineDone(const CheckPagesExistOfflineResult& result);
void OnGetOfflineIdsForClientIdDone(MultipleOfflineIdResult* storage,
@@ -199,6 +201,7 @@ class OfflinePageModelImplTest
std::unique_ptr<OfflinePageModelImpl> model_;
SavePageResult last_save_result_;
int64_t last_save_offline_id_;
+ base::FilePath last_saved_filepath_;
DeletePageResult last_delete_result_;
base::FilePath last_archiver_path_;
int64_t last_deleted_offline_id_;
@@ -255,10 +258,13 @@ void OfflinePageModelImplTest::SetLastPathCreatedByArchiver(
last_archiver_path_ = file_path;
}
-void OfflinePageModelImplTest::OnSavePageDone(SavePageResult result,
- int64_t offline_id) {
+void OfflinePageModelImplTest::OnSavePageDone(
+ SavePageResult result,
+ int64_t offline_id,
+ const base::FilePath& saved_filepath) {
last_save_result_ = result;
last_save_offline_id_ = offline_id;
+ last_saved_filepath_ = saved_filepath;
}
void OfflinePageModelImplTest::OnDeletePageDone(DeletePageResult result) {

Powered by Google App Engine
This is Rietveld 408576698