chrome/browser/android/offline_pages/recent_tab_helper.cc - Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)

Patch Set: Approach for writing to the file afterwards instead. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/offline_pages/recent_tab_helper.cc

diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc

index 064036a99e7e317547e6a0e54f26aa1db79d0b4a..404eed3e0cf3c14407905917f64c46d76b4eee49 100644

--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc

+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc

@@ -400,7 +400,8 @@ void RecentTabHelper::ContinueSnapshotAfterPurge(

void RecentTabHelper::SavePageCallback(SnapshotProgressInfo* snapshot_info,

OfflinePageModel::SavePageResult result,

- int64_t offline_id) {

+ int64_t offline_id,

+ const base::FilePath& saved_filepath) {

DCHECK(snapshot_info->IsForLastN() ||

snapshot_info->request_id == offline_id);

ReportSnapshotCompleted(snapshot_info, result == SavePageResult::SUCCESS);