Get signals working in the EXTRA_DATA section of MHTML

chrome/browser/android/offline_pages/prerendering_loader.cc

Index: chrome/browser/android/offline_pages/prerendering_loader.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.cc b/chrome/browser/android/offline_pages/prerendering_loader.cc
index 0b2f878764963cadf74a4cf1ec95240527f95c2f..25399c9d47e71131e3046e60493cb707c8c2183d 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader.cc
@@ -8,6 +8,7 @@
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "base/time/time.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
@@ -98,6 +99,11 @@ bool PrerenderingLoader::LoadPage(const GURL& url,
     return false;
   }
 
+  // Add this signal to signal_data_.

[fgorski, 2017/03/20 20:43:24]

Consider extracting a method accepting signal name.

[Pete Williamson, 2017/03/20 21:43:52]

Added a new method for this.

+  std::string signal("StartLoading: ");
+  signal += std::to_string(base::Time::Now().ToJavaTime());

[fgorski, 2017/03/20 20:43:24]

Why use java time? Please document that somehow.

[Pete Williamson, 2017/03/20 21:43:52]

What we need is time in milliseconds.  There are two methods that do that,
ToJavaTime, and ToJavascriptTime.  Added a comment in the new method.

+  signal_data_.push_back(signal);
+
   // Create a WebContents instance to define and hold a SessionStorageNamespace
   // for this load request.
   DCHECK(!session_contents_.get());
@@ -152,6 +158,11 @@ void PrerenderingLoader::OnPrerenderStopLoading() {
   // Inform SnapshotController of OnLoad event so it can determine
   // when to consider it really LOADED.
   snapshot_controller_->DocumentOnLoadCompletedInMainFrame();
+
+  // Add this signal to signal_data_.
+  std::string signal("OnLoad: ");
+  signal += std::to_string(base::Time::Now().ToJavaTime());
+  signal_data_.push_back(signal);
 }
 
 void PrerenderingLoader::OnPrerenderDomContentLoaded() {
@@ -168,6 +179,11 @@ void PrerenderingLoader::OnPrerenderDomContentLoaded() {
       // second delay from this event).
       snapshot_controller_->DocumentAvailableInMainFrame();
     }
+
+    // Add this signal to signal_data_.
+    std::string signal("OnDomContentLoaded: ");
+    signal += std::to_string(base::Time::Now().ToJavaTime());
+    signal_data_.push_back(signal);
   }
 }
 
@@ -183,6 +199,12 @@ void PrerenderingLoader::OnPrerenderNetworkBytesChanged(int64_t bytes) {
 
 void PrerenderingLoader::StartSnapshot() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  // Add this signal to signal_data_.
+  std::string signal("Snapshotting: ");
+  signal += std::to_string(base::Time::Now().ToJavaTime());
+  signal_data_.push_back(signal);
+
   HandleLoadEvent();
 }