Get signals working in the EXTRA_DATA section of MHTML

chrome/browser/android/offline_pages/prerendering_loader.h

Index: chrome/browser/android/offline_pages/prerendering_loader.h
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.h b/chrome/browser/android/offline_pages/prerendering_loader.h
index 7e45fef375163996eddbae437e53c3363f45719d..85d21553cbfab42f931766075d1f19947da56d0e 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.h
+++ b/chrome/browser/android/offline_pages/prerendering_loader.h
@@ -6,6 +6,8 @@
 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_
 
 #include <memory>
+#include <string>
+#include <vector>
 
 #include "base/callback.h"
 #include "chrome/browser/android/offline_pages/prerender_adapter.h"
@@ -82,6 +84,8 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
   // Returns true if the lowbar of snapshotting a page is met.
   virtual bool IsLowbarMet();
 
+  const std::vector<std::string>& GetSignalData() { return signal_data_; }

[Dmitry Titov, 2017/03/16 02:28:20]

"Signal" is very generic, it would not be clear to the code reader which signals
are meant here. Some longer name for those signals could be better, like
LoadingCompletenessSignals?

[Pete Williamson, 2017/03/17 23:28:32]

Renamed to GetLoadingSignalData.

+
  private:
   // State of the loader (only one request may be active at a time).
   enum class State {
@@ -120,6 +124,9 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
   // storage namespace for rendering. This will NOT have the loaded page.
   std::unique_ptr<content::WebContents> session_contents_;
 
+  // Signal data collected for this rendering attempt
+  std::vector<std::string> signal_data_;
+
   // Callback to call when the active load request completes, fails, or is
   // canceled.
   LoadPageCallback load_done_callback_;