Get signals working in the EXTRA_DATA section of MHTML

chrome/browser/flag_descriptions.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/flag_descriptions.h"
 
 namespace flag_descriptions {
 
 //  Material Design version of chrome://bookmarks
 
@@ skipping 2012 matching lines @@
     R"*(that the user can click on it to download the page later.)*";
 
 const char kOfflinePagesSvelteConcurrentLoadingName[] =
     "Enables concurrent background loading on svelte.";
 
 const char kOfflinePagesSvelteConcurrentLoadingDescription[] =
     "Enables concurrent background loading (or downloading) of pages on "
     "Android svelte (512MB RAM) devices. Otherwise, background loading will "
     "happen when the svelte device is idle.";
 
+const char kOfflinePagesLoadSignalCollectingName[] =
+    "Enables collecting load timing data for offline page snapshots.";

[Dmitry Titov, 2017/03/31 18:05:53]

Same note as in .h file.

I think we are not really after 'timing' signals because times in themselves say
little to us. For example, percentage of loaded resources says more... Trying to
avoid confusion for others reading the code. "telemetry" or "loading
completeness" are probably better than "timing".

[Pete Williamson, 2017/03/31 21:58:04]

Changed to "Enables load completeness data colllection " ...

+
+const char kOfflinePagesLoadSignalCollectingDescription[] =
+    "Enables load timing data collection while writing an offline page. "
+    "This data is collected in the snapshotted offline page to allow "
+    "data analysis to improve deciding when to make the offline snapshot.";
+
 const char kOfflinePagesPrefetchingName[] =
     "Enables suggested offline pages to be prefetched.";
 
 const char kOfflinePagesPrefetchingDescription[] =
     "Enables suggested offline pages to be prefetched, so useful content is "
     "available while offline.";
 
 const char kOfflinePagesSharingName[] = "Enables offline pages to be shared.";
 
 const char kOfflinePagesSharingDescription[] =
@@ skipping 840 matching lines @@
 const char kEnableEhvInputName[] =
     "Emoji, handwriting and voice input on opt-in IME menu";
 
 const char kEnableEhvInputDescription[] =
     "Enable access to emoji, handwriting and voice input form opt-in IME "
     "menu.";
 
 #endif  // #if defined(OS_CHROMEOS)
 
 }  // namespace flag_descriptions