Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/offline_page_request_job.h" 5 #include "chrome/browser/android/offline_pages/offline_page_request_job.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/feature_list.h" 8 #include "base/feature_list.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 TestOfflinePageArchiver(const GURL& url, 208 TestOfflinePageArchiver(const GURL& url,
209 const base::FilePath& archive_file_path, 209 const base::FilePath& archive_file_path,
210 int archive_file_size) 210 int archive_file_size)
211 : url_(url), 211 : url_(url),
212 archive_file_path_(archive_file_path), 212 archive_file_path_(archive_file_path),
213 archive_file_size_(archive_file_size) {} 213 archive_file_size_(archive_file_size) {}
214 ~TestOfflinePageArchiver() override {} 214 ~TestOfflinePageArchiver() override {}
215 215
216 void CreateArchive(const base::FilePath& archives_dir, 216 void CreateArchive(const base::FilePath& archives_dir,
217 const CreateArchiveParams& create_archive_params, 217 const CreateArchiveParams& create_archive_params,
218 const std::vector<std::string>& extra_data,
218 const CreateArchiveCallback& callback) override { 219 const CreateArchiveCallback& callback) override {
219 base::ThreadTaskRunnerHandle::Get()->PostTask( 220 base::ThreadTaskRunnerHandle::Get()->PostTask(
220 FROM_HERE, 221 FROM_HERE,
221 base::Bind(callback, this, ArchiverResult::SUCCESSFULLY_CREATED, 222 base::Bind(callback, this, ArchiverResult::SUCCESSFULLY_CREATED,
222 url_, archive_file_path_, base::string16(), 223 url_, archive_file_path_, base::string16(),
223 archive_file_size_)); 224 archive_file_size_));
224 } 225 }
225 226
226 private: 227 private:
227 const GURL url_; 228 const GURL url_;
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 void OfflinePageRequestJobTest::ExpectOpenFileErrorCode(int result) { 496 void OfflinePageRequestJobTest::ExpectOpenFileErrorCode(int result) {
496 histogram_tester_.ExpectUniqueSample(kOpenFileErrorCodeHistogram, -result, 1); 497 histogram_tester_.ExpectUniqueSample(kOpenFileErrorCodeHistogram, -result, 1);
497 } 498 }
498 499
499 void OfflinePageRequestJobTest::SavePage( 500 void OfflinePageRequestJobTest::SavePage(
500 const GURL& url, 501 const GURL& url,
501 const ClientId& client_id, 502 const ClientId& client_id,
502 const GURL& original_url, 503 const GURL& original_url,
503 std::unique_ptr<OfflinePageArchiver> archiver) { 504 std::unique_ptr<OfflinePageArchiver> archiver) {
504 OfflinePageModel::SavePageParams save_page_params; 505 OfflinePageModel::SavePageParams save_page_params;
506 std::vector<std::string> signal_data;
505 save_page_params.url = url; 507 save_page_params.url = url;
506 save_page_params.client_id = client_id; 508 save_page_params.client_id = client_id;
507 save_page_params.original_url = original_url; 509 save_page_params.original_url = original_url;
508 OfflinePageModelFactory::GetForBrowserContext(profile())->SavePage( 510 OfflinePageModelFactory::GetForBrowserContext(profile())->SavePage(
509 save_page_params, 511 save_page_params,
510 std::move(archiver), 512 std::move(archiver),
513 signal_data,
511 base::Bind(&OfflinePageRequestJobTest::OnSavePageDone, 514 base::Bind(&OfflinePageRequestJobTest::OnSavePageDone,
512 base::Unretained(this))); 515 base::Unretained(this)));
513 RunUntilIdle(); 516 RunUntilIdle();
514 } 517 }
515 518
516 void OfflinePageRequestJobTest::OnSavePageDone(SavePageResult result, 519 void OfflinePageRequestJobTest::OnSavePageDone(SavePageResult result,
517 int64_t offline_id) { 520 int64_t offline_id) {
518 ASSERT_EQ(SavePageResult::SUCCESS, result); 521 ASSERT_EQ(SavePageResult::SUCCESS, result);
519 if (offline_id_ == -1) 522 if (offline_id_ == -1)
520 offline_id_ = offline_id; 523 offline_id_ = offline_id;
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest()); 900 ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest());
898 EXPECT_EQ(offline_id4(), 901 EXPECT_EQ(offline_id4(),
899 offline_page_tab_helper()->GetOfflinePageForTest()->offline_id); 902 offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
900 ExpectOneUniqueSampleForAggregatedRequestResult( 903 ExpectOneUniqueSampleForAggregatedRequestResult(
901 OfflinePageRequestJob::AggregatedRequestResult:: 904 OfflinePageRequestJob::AggregatedRequestResult::
902 SHOW_OFFLINE_ON_DISCONNECTED_NETWORK); 905 SHOW_OFFLINE_ON_DISCONNECTED_NETWORK);
903 ExpectOpenFileErrorCode(net::ERR_FILE_NOT_FOUND); 906 ExpectOpenFileErrorCode(net::ERR_FILE_NOT_FOUND);
904 } 907 }
905 908
906 } // namespace offline_pages 909 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698