third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2683433002: Set m_graphicsLayer as fixed position container

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2683433002: Set m_graphicsLayer as fixed position container (Closed)

Patch Set: Add test, remove cc workaround Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index bf203b4571dceb89135ecc6d412ddf2f908d6194..54a33c07c3d984d4195192cfadaf72e4550ed87d 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -1515,10 +1515,8 @@ void CompositedLayerMapping::registerScrollingLayers() {

bool isContainer =

m_owningLayer.layoutObject()->style()->canContainFixedPositionObjects() &&

!m_owningLayer.isRootLayer();

- // FIXME: we should make certain that childForSuperLayers will never be the

- // m_squashingContainmentLayer here

scrollingCoordinator->setLayerIsContainerForFixedPositionLayers(

- childForSuperlayers(), isContainer);

+ m_graphicsLayer.get(), isContainer);

}

void CompositedLayerMapping::updateInternalHierarchy() {

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/fixed-position-container-expected.html ('k') | no next file » | no next file with comments »