Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ios/chrome/browser/ui/omnibox/omnibox_text_field_ios_unittest.mm

Issue 2683423003: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:unit_tests to ARC. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/omnibox/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/omnibox/omnibox_text_field_ios_unittest.mm
diff --git a/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios_unittest.mm b/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios_unittest.mm
index 4b0eddd49942ef1dcfa4388d09ca5e786695a504..6d2beb90a2e4e2618dc7fc3ae18d109bb9a91d56 100644
--- a/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios_unittest.mm
+++ b/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios_unittest.mm
@@ -7,7 +7,6 @@
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
-#include "base/mac/scoped_nsobject.h"
#include "base/path_service.h"
#include "base/strings/string_split.h"
#include "base/strings/sys_string_conversions.h"
@@ -17,6 +16,10 @@
#include "testing/platform_test.h"
#include "ui/base/l10n/l10n_util_mac.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
// A category for making existing methods visible for use in these tests.
@interface OmniboxTextFieldIOS (VisibleForTesting)
- (CGRect)rectForDrawTextInRect:(CGRect)rect;
@@ -31,7 +34,7 @@ class OmniboxTextFieldIOSTest : public PlatformTest {
// This rect is fairly arbitrary. The text field just needs a non-zero width
// so that the pre-edit label's text alignment can be tested.
CGRect rect = CGRectMake(0, 0, 100, 20);
- textfield_.reset([[OmniboxTextFieldIOS alloc] initWithFrame:rect]);
+ textfield_ = [[OmniboxTextFieldIOS alloc] initWithFrame:rect];
[[[UIApplication sharedApplication] keyWindow] addSubview:textfield_];
};
@@ -116,7 +119,7 @@ class OmniboxTextFieldIOSTest : public PlatformTest {
[textfield_ resignFirstResponder];
}
- base::scoped_nsobject<OmniboxTextFieldIOS> textfield_;
+ OmniboxTextFieldIOS* textfield_;
};
TEST_F(OmniboxTextFieldIOSTest, BecomeFirstResponderAddsCopyURLMenuItem) {
« no previous file with comments | « ios/chrome/browser/ui/omnibox/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698