Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: components/subresource_filter/content/common/document_subresource_filter.h

Issue 2683413003: Introduce AsyncDocumentSubresourceFilter. (Closed)
Patch Set: Fix fix blink test build. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/common/document_subresource_filter.h
diff --git a/components/subresource_filter/content/common/document_subresource_filter.h b/components/subresource_filter/content/common/document_subresource_filter.h
index 8de7df3700d0ebba50e2f7951cb92abf86c22494..7e5b299d3f4f6271e7b425283336ccd63c7c9df4 100644
--- a/components/subresource_filter/content/common/document_subresource_filter.h
+++ b/components/subresource_filter/content/common/document_subresource_filter.h
@@ -21,6 +21,7 @@
#include "components/subresource_filter/core/common/indexed_ruleset.h"
#include "components/subresource_filter/core/common/proto/rules.pb.h"
#include "third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h"
+#include "third_party/WebKit/public/platform/WebDocumentSubresourceFilterLoadPolicy.h"
jochen (gone - plz use gerrit) 2017/02/16 14:46:21 please change subresource_filter/content/common/DE
pkalinnikov 2017/02/17 17:51:38 Now common/ doesn't depend on blink.
#include "url/gurl.h"
#include "url/origin.h"
@@ -57,13 +58,15 @@ class DocumentSubresourceFilter
: public blink::WebDocumentSubresourceFilter,
public base::SupportsWeakPtr<DocumentSubresourceFilter> {
public:
+ using LoadPolicy = blink::WebDocumentSubresourceFilterLoadPolicy;
+
// Constructs a new filter that will:
// -- Operate in a manner prescribed in |activation_state|.
// -- Filter subresource loads in the scope of a document loaded from
// |document_origin|.
// -- Hold a reference to and use |ruleset| for its entire lifetime.
// -- Invoke |first_disallowed_load_callback|, if it is non-null, on the
- // first disallowed subresource load.
+ // first reportDisallowedLoad() call.
DocumentSubresourceFilter(url::Origin document_origin,
ActivationState activation_state,
scoped_refptr<const MemoryMappedRuleset> ruleset,

Powered by Google App Engine
This is Rietveld 408576698