components/subresource_filter/content/common/document_subresource_filter.h - Issue 2683413003: Introduce AsyncDocumentSubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/common/document_subresource_filter.h

Issue 2683413003: Introduce AsyncDocumentSubresourceFilter. (Closed)

Patch Set: Address comments from csharrison@. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc ('K') | « components/subresource_filter/content/browser/verified_ruleset_dealer.h ('k') | components/subresource_filter/core/common/indexed_ruleset.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/common/document_subresource_filter.h

diff --git a/components/subresource_filter/content/common/document_subresource_filter.h b/components/subresource_filter/content/common/document_subresource_filter.h

index 8de7df3700d0ebba50e2f7951cb92abf86c22494..b2e2010868b2a367cf9284ebf8ef6f52feb999e6 100644

--- a/components/subresource_filter/content/common/document_subresource_filter.h

+++ b/components/subresource_filter/content/common/document_subresource_filter.h

@@ -63,7 +63,7 @@ class DocumentSubresourceFilter

// |document_origin|.

// -- Hold a reference to and use |ruleset| for its entire lifetime.

// -- Invoke |first_disallowed_load_callback|, if it is non-null, on the

- // first disallowed subresource load.

+ // first reportDisallowedLoad() call.

DocumentSubresourceFilter(url::Origin document_origin,

ActivationState activation_state,

scoped_refptr<const MemoryMappedRuleset> ruleset,