Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: components/subresource_filter/content/browser/async_document_subresource_filter.cc

Issue 2683413003: Introduce AsyncDocumentSubresourceFilter. (Closed)
Patch Set: Address more comments from engedy@. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/subresource_filter/content/browser/async_document_subresour ce_filter.h"
6
7 #include <utility>
8
9 #include "base/bind.h"
10 #include "base/bind_helpers.h"
11 #include "base/callback.h"
12 #include "base/location.h"
13 #include "base/logging.h"
14 #include "base/task_runner_util.h"
15 #include "base/threading/sequenced_task_runner_handle.h"
16 #include "components/subresource_filter/core/common/memory_mapped_ruleset.h"
17
18 namespace subresource_filter {
19
20 // AsyncDocumentSubresourceFilter::InitializationParams ------------------------
21
22 using InitializationParams =
23 AsyncDocumentSubresourceFilter::InitializationParams;
24
25 InitializationParams::InitializationParams() = default;
26
27 InitializationParams::InitializationParams(GURL document_url,
28 ActivationLevel activation_level,
29 bool measure_performance)
30 : document_url(std::move(document_url)),
31 parent_activation_state(activation_level) {
32 DCHECK_NE(ActivationLevel::DISABLED, activation_level);
33 parent_activation_state.measure_performance = measure_performance;
34 }
35
36 InitializationParams::InitializationParams(
37 GURL document_url,
38 url::Origin parent_document_origin,
39 ActivationState parent_activation_state)
40 : document_url(std::move(document_url)),
41 parent_document_origin(std::move(parent_document_origin)),
42 parent_activation_state(parent_activation_state) {
43 DCHECK_NE(ActivationLevel::DISABLED,
44 parent_activation_state.activation_level);
45 }
46
47 InitializationParams::~InitializationParams() = default;
48 InitializationParams::InitializationParams(InitializationParams&&) = default;
49 InitializationParams& InitializationParams::operator=(InitializationParams&&) =
50 default;
51
52 // AsyncDocumentSubresourceFilter ----------------------------------------------
53
54 AsyncDocumentSubresourceFilter::AsyncDocumentSubresourceFilter(
55 VerifiedRuleset::Handle* ruleset_handle,
56 InitializationParams params,
57 base::Callback<void(ActivationState)> activation_state_callback,
58 base::OnceClosure first_disallowed_load_callback)
59 : task_runner_(ruleset_handle->task_runner()),
60 core_(new Core(), base::OnTaskRunnerDeleter(task_runner_)),
61 first_disallowed_load_callback_(
62 std::move(first_disallowed_load_callback)) {
63 DCHECK_NE(ActivationLevel::DISABLED,
64 params.parent_activation_state.activation_level);
65
66 // Note: It is safe to post |ruleset_handle|'s VerifiedRuleset pointer,
67 // because a task to delete it can only be posted to (and, therefore,
68 // processed by) |task_runner| after this method returns, hence after the
69 // below task is posted.
70 base::PostTaskAndReplyWithResult(
71 task_runner_, FROM_HERE,
72 base::Bind(&Core::Initialize, base::Unretained(core_.get()),
73 base::Passed(&params), ruleset_handle->ruleset_.get()),
74 std::move(activation_state_callback));
75 }
76
77 AsyncDocumentSubresourceFilter::~AsyncDocumentSubresourceFilter() {
78 DCHECK(thread_checker_.CalledOnValidThread());
79 }
80
81 void AsyncDocumentSubresourceFilter::GetLoadPolicyForSubdocument(
82 const GURL& subdocument_url,
83 LoadPolicyCallback result_callback) {
84 DCHECK(thread_checker_.CalledOnValidThread());
85
86 // TODO(pkalinnikov): Think about avoiding copy of |subdocument_url| if it is
87 // too big and won't be allowed anyway (e.g., it's a data: URI).
88 base::PostTaskAndReplyWithResult(
89 task_runner_, FROM_HERE,
90 base::Bind(
91 [](AsyncDocumentSubresourceFilter::Core* core,
92 const GURL& subdocument_url) {
93 DCHECK(core);
94 DocumentSubresourceFilter* filter = core->filter();
95 return filter ? filter->GetLoadPolicyForSubdocument(subdocument_url)
96 : LoadPolicy::Allow;
97 },
98 core_.get(), subdocument_url),
99 std::move(result_callback));
100 }
101
102 void AsyncDocumentSubresourceFilter::ReportDisallowedLoad() {
103 if (!first_disallowed_load_callback_.is_null())
104 std::move(first_disallowed_load_callback_).Run();
105
106 auto report_disallowed_load = [](AsyncDocumentSubresourceFilter::Core* core) {
107 DCHECK(core);
108 DocumentSubresourceFilter* filter = core->filter();
109 if (filter)
110 filter->reportDisallowedLoad();
111 };
112 task_runner_->PostTask(FROM_HERE,
113 base::Bind(report_disallowed_load, core_.get()));
114 }
115
116 // AsyncDocumentSubresourceFilter::Core ----------------------------------------
117
118 AsyncDocumentSubresourceFilter::Core::Core() {
119 thread_checker_.DetachFromThread();
120 }
121
122 AsyncDocumentSubresourceFilter::Core::~Core() {
123 DCHECK(thread_checker_.CalledOnValidThread());
124 }
125
126 ActivationState AsyncDocumentSubresourceFilter::Core::Initialize(
127 InitializationParams params,
128 VerifiedRuleset* verified_ruleset) {
129 DCHECK(thread_checker_.CalledOnValidThread());
130 DCHECK(verified_ruleset);
131
132 if (!verified_ruleset->Get())
133 return ActivationState(ActivationLevel::DISABLED);
134
135 ActivationState activation_state = ComputeActivationState(
136 params.document_url, params.parent_document_origin,
137 params.parent_activation_state, verified_ruleset->Get());
138
139 DCHECK_NE(ActivationLevel::DISABLED, activation_state.activation_level);
140 // Note: Empty |first_disallowed_load_callback| is supplied to the
141 // DocumentSubresourceFilter's constructor, because ADSF has its own callback
142 // and invokes it directly on the UI thread without hopping between threads.
143 filter_.emplace(url::Origin(params.document_url), activation_state,
144 verified_ruleset->Get(), base::OnceClosure());
145
146 return activation_state;
147 }
148
149 } // namespace subresource_filter
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698