components/subresource_filter/content/browser/DEPS - Issue 2683413003: Introduce AsyncDocumentSubresourceFilter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/subresource_filter/content/browser/DEPS

Issue 2683413003: Introduce AsyncDocumentSubresourceFilter. (Closed)

Patch Set: Address more comments from engedy@. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/keyed_service/core",	2 "+components/keyed_service/core",

3 "+content/public/browser",	3 "+content/public/browser",

4 "+components/safe_browsing_db",	4 "+components/safe_browsing_db",

	5 "+third_party/WebKit/public/platform",
	jochen (gone - plz use gerrit) 2017/02/15 10:32:10 please only depend on individual headers please only depend on individual headers pkalinnikov 2017/02/15 11:47:40 How about this? Show quoted text On 2017/02/15 10:32:10, jochen wrote: > please only depend on individual headers How about this?
5 "+ui/base/page_transition_types.h",	6 "+ui/base/page_transition_types.h",

6 ]	7 ]

OLD	NEW