Issue 2683403003: Improve error message in flaky test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2683403003: Improve error message in flaky test (Closed)

Created:
3 years, 10 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 7 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, nweiz

Target Ref:
refs/heads/master

Visibility:
Public.

Improve error message in flaky test This test is flaky (see #28712), but there are many test cases that hit this line. This should help narrow things down when this fails in minified mode (where it is hard to extract what the stack trace looks like). R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/5615f72247855a63c27b1f42695e3b2626cade6e

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tests/corelib/list_unmodifiable_test.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

3 years, 7 months ago (2017-04-28 22:35:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5615f72247855a63c27b1f42695e3b2626cade6e (presubmit successful).