Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 2683403002: Handle equivalence for generic mixins. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M tests/compiler/dart2js/kernel/impact_test.dart View 1 3 chunks +12 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-10 10:55:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2683403002/diff/1/tests/compiler/dart2js/kernel/impact_test.dart File tests/compiler/dart2js/kernel/impact_test.dart (right): https://codereview.chromium.org/2683403002/diff/1/tests/compiler/dart2js/kernel/impact_test.dart#newcode664 tests/compiler/dart2js/kernel/impact_test.dart:664: class GenericSub<X, Y> extends GenericSuper<X, Y> it might ...
3 years, 10 months ago (2017-02-10 22:11:22 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 39946b04684cbf2db61f00f825e1527a0641fce8 (presubmit successful).
3 years, 10 months ago (2017-02-12 09:46:12 UTC) #5
Johnni Winther
3 years, 10 months ago (2017-02-12 09:46:44 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2683403002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/impact_test.dart (right):

https://codereview.chromium.org/2683403002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/impact_test.dart:664: class GenericSub<X, Y>
extends GenericSuper<X, Y>
On 2017/02/10 22:11:22, Siggi Cherem (dart-lang) wrote:
> it might be interesting to test using different names for the type variables
> too.

Done.

Powered by Google App Engine
This is Rietveld 408576698