Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

Issue 2683233006: DevTools: Fix button layout glitches on Memory panel. (Closed)
Patch Set: addressing comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 27 matching lines...) Expand all
38 constructor(profilesPanel) { 38 constructor(profilesPanel) {
39 super(); 39 super();
40 40
41 this._panel = profilesPanel; 41 this._panel = profilesPanel;
42 42
43 this.element.classList.add('profile-launcher-view'); 43 this.element.classList.add('profile-launcher-view');
44 this.element.classList.add('panel-enabler-view'); 44 this.element.classList.add('panel-enabler-view');
45 45
46 this._contentElement = this.element.createChild('div', 'profile-launcher-vie w-content'); 46 this._contentElement = this.element.createChild('div', 'profile-launcher-vie w-content');
47 this._innerContentElement = this._contentElement.createChild('div'); 47 this._innerContentElement = this._contentElement.createChild('div');
48 var targetSpan = this._contentElement.createChild('span'); 48 var controlDiv = this._contentElement.createChild('div', 'hbox profile-launc her-control');
49 var selectTargetText = targetSpan.createChild('span'); 49 var targetDiv = controlDiv.createChild('div', 'hbox profile-launcher-target' );
50 selectTargetText.textContent = Common.UIString('Target:'); 50 targetDiv.createChild('div').textContent = Common.UIString('Target:');
51 var targetsSelect = targetSpan.createChild('select', 'chrome-select'); 51 var targetsSelect = targetDiv.createChild('select', 'chrome-select');
52 new Profiler.TargetsComboBoxController(targetsSelect, targetSpan); 52 new Profiler.TargetsComboBoxController(targetsSelect, targetDiv);
53 this._controlButton = UI.createTextButton('', this._controlButtonClicked.bin d(this), 'control-profiling'); 53 this._controlButton = UI.createTextButton('', this._controlButtonClicked.bin d(this));
54 this._contentElement.appendChild(this._controlButton); 54 controlDiv.appendChild(this._controlButton);
55 this._recordButtonEnabled = true; 55 this._recordButtonEnabled = true;
56 this._loadButton = UI.createTextButton(Common.UIString('Load'), this._loadBu ttonClicked.bind(this), 'load-profile'); 56 this._loadButton = UI.createTextButton(Common.UIString('Load'), this._loadBu ttonClicked.bind(this), 'load-profile');
57 this._contentElement.appendChild(this._loadButton); 57 this._contentElement.appendChild(this._loadButton);
58 SDK.targetManager.observeTargets(this); 58 SDK.targetManager.observeTargets(this);
59 } 59 }
60 60
61 /** 61 /**
62 * @return {?UI.SearchableView} 62 * @return {?UI.SearchableView}
63 */ 63 */
64 searchableView() { 64 searchableView() {
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 profileFinished() { 240 profileFinished() {
241 this._isProfiling = false; 241 this._isProfiling = false;
242 this._updateControls(); 242 this._updateControls();
243 } 243 }
244 }; 244 };
245 245
246 /** @enum {symbol} */ 246 /** @enum {symbol} */
247 Profiler.MultiProfileLauncherView.Events = { 247 Profiler.MultiProfileLauncherView.Events = {
248 ProfileTypeSelected: Symbol('ProfileTypeSelected') 248 ProfileTypeSelected: Symbol('ProfileTypeSelected')
249 }; 249 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698