Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2683233005: Set caret width based on device scale factor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 674d218fc8162ce891b1fb3f93482442972b1d64..41bf23af6485a2a9e51be2d9f09ed57638ce3e5a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -4543,12 +4543,16 @@ LayoutRect LayoutBox::localCaretRect(InlineBox* box,
// FIXME: Paint the carets inside empty blocks differently than the carets
// before/after elements.
- LayoutRect rect(location(), LayoutSize(caretWidth(), size().height()));
+ LayoutRect rect(
+ location(),
+ LayoutSize(caretWidth(frameView()->getHostWindow()), size().height()));
oshima 2017/02/10 19:55:16 just get noce
malaykeshav 2017/02/10 21:00:54 Done
bool ltr =
box ? box->isLeftToRightDirection() : style()->isLeftToRightDirection();
if ((!caretOffset) ^ ltr)
- rect.move(LayoutSize(size().width() - caretWidth(), LayoutUnit()));
+ rect.move(
+ LayoutSize(size().width() - caretWidth(frameView()->getHostWindow()),
+ LayoutUnit()));
if (box) {
RootInlineBox& rootBox = box->root();

Powered by Google App Engine
This is Rietveld 408576698