Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: chrome/browser/resources/settings/device_page/storage.js

Issue 2683123002: MD Settings: Storage: Use hidden attribute instead of dom-if binding to hide a row. (Closed)
Patch Set: Remove unncecessary change. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/storage.js
diff --git a/chrome/browser/resources/settings/device_page/storage.js b/chrome/browser/resources/settings/device_page/storage.js
index 84453c690d6e69289bf54520ffc7111272812032..6649b8397e41b38e246e59b5070d050a1c6e71a6 100644
--- a/chrome/browser/resources/settings/device_page/storage.js
+++ b/chrome/browser/resources/settings/device_page/storage.js
@@ -82,9 +82,11 @@ Polymer({
cr.addWebUIListener(
'storage-android-size-changed',
this.handleAndroidSizeChanged_.bind(this));
- cr.addWebUIListener(
- 'storage-other-users-size-changed',
- this.handleOtherUsersSizeChanged_.bind(this));
+ if (!this.isGuest_) {
+ cr.addWebUIListener(
+ 'storage-other-users-size-changed',
+ this.handleOtherUsersSizeChanged_.bind(this));
+ }
cr.addWebUIListener(
'storage-drive-enabled-changed',
this.handleDriveEnabledChanged_.bind(this));
@@ -178,7 +180,8 @@ Polymer({
* @private
*/
handleDriveCacheSizeChanged_: function(size) {
- this.$.driveCacheSize.textContent = size;
+ if (this.driveEnabled_)
+ this.$$('#driveCacheSize').textContent = size;
},
/**
@@ -196,7 +199,8 @@ Polymer({
* @private
*/
handleAndroidSizeChanged_: function(size) {
- this.$.androidSize.textContent = size;
+ if (this.androidEnabled_)
+ this.$$('#androidSize').textContent = size;
},
/**
@@ -204,7 +208,8 @@ Polymer({
* @private
*/
handleOtherUsersSizeChanged_: function(size) {
- this.$.otherUsersSize.textContent = size;
+ if (!this.isGuest_)
+ this.$$('#otherUsersSize').textContent = size;
},
/**

Powered by Google App Engine
This is Rietveld 408576698