Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2683043002: Ensure that returned cached source have the same actual URI. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure that returned cached source have the same actual URI. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c97317cee9806293530c4d6ea547852cb0bfaaa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/context/source.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-08 21:26:14 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-08 21:30:37 UTC) #2
scheglov
3 years, 10 months ago (2017-02-08 21:45:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c97317cee9806293530c4d6ea547852cb0bfaaa1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698