Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2683033007: Revert "Reapply "Use CodeSourceMap for stack traces (still JIT only)."" (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Reapply "Use CodeSourceMap for stack traces (still JIT only)."" This reverts commit bee82fef8b483e91ab42324acc4639481daa81f2. Revert "Use zone memory for StackTrace::ToCString." This reverts commit 4e8b265ea0c4d56d2e25f107d9a9cc4b975ef588. The later CL somehow caused hangs in some service tests. Committed: https://github.com/dart-lang/sdk/commit/15a9eafb77bca600caad6cf252b75441aaab3914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -428 lines) Patch
M runtime/tests/vm/dart/inline_stack_frame_test.dart View 3 chunks +15 lines, -24 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 5 chunks +6 lines, -12 lines 0 comments Download
M runtime/vm/code_descriptors.h View 4 chunks +22 lines, -56 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 5 chunks +31 lines, -106 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +20 lines, -26 lines 0 comments Download
M runtime/vm/disassembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 2 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 5 chunks +11 lines, -20 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 2 chunks +3 lines, -11 lines 0 comments Download
M runtime/vm/object.cc View 5 chunks +66 lines, -42 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/vm/zone_text_buffer.h View 1 chunk +0 lines, -38 lines 0 comments Download
D runtime/vm/zone_text_buffer.cc View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
rmacnak
3 years, 10 months ago (2017-02-09 21:13:16 UTC) #2
rmacnak
3 years, 10 months ago (2017-02-09 21:14:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
15a9eafb77bca600caad6cf252b75441aaab3914 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698